Hi Akhil, @Akhil: Is there a chance getting this change into 20.11?
Any more comments or anyone see any potential issues with this approach? Regards, Arek -----Original Message----- From: Doherty, Declan <[email protected]> Sent: piątek, 31 lipca 2020 16:34 To: Kusztal, ArkadiuszX <[email protected]>; [email protected] Cc: [email protected]; Trahe, Fiona <[email protected]>; [email protected]; [email protected]; Zhang, Roy Fan <[email protected]>; Ananyev, Konstantin <[email protected]> Subject: Re: [PATCH] [RFC] cryptodev: move AES-GMAC to aead algorithms On 29/07/2020 3:22 PM, Arek Kusztal wrote: > This is proposal to move AES-GMAC algorithm to AEAD set of algorithms. > It is however not 100% conformant GMAC as instead of aad pointer data > to be authenticated is passed normally and aead.data.length field is > used to specify length of data to be authenticated. > Reason behind this move is that GMAC is variant of GCM so it may > simplify implementations that are using these algorithms (mainly IPsec). > AES-GMAC therefore needs to be removed from auth algorithms. > > Signed-off-by: Arek Kusztal <[email protected]> > --- .. > I think this makes sense in light of how AES-GMAC support is specified in the IPsec GMAC rfc (https://tools.ietf.org/html/rfc4543) Acked-by: Declan Doherty <[email protected]>
