> -----Original Message----- > From: wangyunjian <[email protected]> > Sent: Monday, July 27, 2020 7:33 PM > To: [email protected]; Rao, Nikhil <[email protected]> > Cc: [email protected]; [email protected]; Yunjian Wang > <[email protected]>; [email protected] > Subject: [dpdk-dev] [PATCH] eventdev: fix return value of null not checked > > From: Yunjian Wang <[email protected]> > > The function rte_zmalloc() could return NULL, the return value need to be > checked. > > Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation") > Cc: [email protected] > > Signed-off-by: Yunjian Wang <[email protected]> > --- > lib/librte_eventdev/rte_event_eth_tx_adapter.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/librte_eventdev/rte_event_eth_tx_adapter.c > b/lib/librte_eventdev/rte_event_eth_tx_adapter.c > index bb21dc407..86287b4e6 100644 > --- a/lib/librte_eventdev/rte_event_eth_tx_adapter.c > +++ b/lib/librte_eventdev/rte_event_eth_tx_adapter.c > @@ -734,6 +734,8 @@ txa_service_queue_add(uint8_t id, > > qdone = rte_zmalloc(txa->mem_name, > nb_queues * sizeof(*qdone), 0); > + if (qdone == NULL) > + return -ENOMEM;
Reviewed-by: Nikhil Rao <[email protected]> > j = 0; > for (i = 0; i < nb_queues; i++) { > if (txa_service_is_queue_added(txa, eth_dev, i)) > -- > 2.23.0 >
