> -----Original Message----- > From: dev <dev-boun...@dpdk.org> On Behalf Of Vikas Gupta > Sent: Wednesday, 12 August, 2020 08:31 > To: dev@dpdk.org; akhil.go...@nxp.com > Cc: ajit.khapa...@broadcom.com; vikram.prak...@broadcom.com; Vikas > Gupta <vikas.gu...@broadcom.com>; Raveendra Padasalagi > <raveendra.padasal...@broadcom.com> > Subject: [dpdk-dev] [PATCH v1 8/8] crypto/bcmfs: add crypto pmd into > cryptodev test > > Add test suites for supported algorithms by bcmfs crypto pmd > > Signed-off-by: Vikas Gupta <vikas.gu...@broadcom.com> > Signed-off-by: Raveendra Padasalagi > <raveendra.padasal...@broadcom.com> > Reviewed-by: Ajit Khaparde <ajit.khapa...@broadcom.com> > --- > app/test/test_cryptodev.c | 261
[Adam] The test suites set was refactored in recent months to use one big list of tests and run/skip them depending on the capability checks. I strongly propose to do this also for your new BCMFS PMD. Have a look at e.g. QAT PMD test suite in the same file. It has one function to properly initialize the run (check the device id) and then it uses big common area of individual tests (some of them are skipped because of requiring specific capabilities). Adam Dybkowski
