> -----Original Message-----
> From: Jerin Jacob <[email protected]>
> Sent: Tuesday, August 18, 2020 3:34 PM
> To: Kiran Kumar Kokkilagadda <[email protected]>
> Cc: Jerin Jacob Kollanukkaran <[email protected]>; Nithin Kumar Dabilpuram
> <[email protected]>; dpdk-dev <[email protected]>; Thomas Monjalon
> <[email protected]>; Ferruh Yigit <[email protected]>; Andrew
> Rybchenko <[email protected]>; Ori Kam <[email protected]>;
> Ziyang Xuan <[email protected]>; Xiaoyun Wang
> <[email protected]>; Guoyang Zhou
> <[email protected]>; Rosen Xu <[email protected]>; Beilei Xing
> <[email protected]>; [email protected]; Rasesh Mody
> <[email protected]>; Shahed Shaikh <[email protected]>; Qiming Yang
> <[email protected]>; Qi Zhang <[email protected]>; Wiles, Keith
> <[email protected]>; Hemant Agrawal <[email protected]>;
> Sachin Saxena <[email protected]>; Zhao1, Wei <[email protected]>;
> John Daley <[email protected]>; Hyong Youb Kim <[email protected]>;
> Chas Williams <[email protected]>; Matan Azrad <[email protected]>;
> Shahaf Shuler <[email protected]>; Slava Ovsiienko
> <[email protected]>; Rahul Lakkireddy
> <[email protected]>; Gaetan Rivet <[email protected]>; Liron Himi
> <[email protected]>; Jingjing Wu <[email protected]>; Wei Hu (Xavier
> <[email protected]>; Min Hu (Connor <[email protected]>; Yisen
> Zhuang <[email protected]>; Ajit Khaparde
> <[email protected]>; Somnath Kotur
> <[email protected]>; Jasvinder Singh
> <[email protected]>; Cristian Dumitrescu
> <[email protected]>
> Subject: [EXT] Re: [dpdk-dev] [PATCH v3 2/2] net/octeontx2: add rss hash level
> support
> 
> External Email
> 
> ----------------------------------------------------------------------
> On Tue, Aug 18, 2020 at 12:52 PM <[email protected]> wrote:
> >
> > From: Kiran Kumar K <[email protected]>
> >
> > Add support to choose rss hash level from ethdev rss config.
> >
> > Signed-off-by: Kiran Kumar K <[email protected]>
> > ---
> >  drivers/net/octeontx2/otx2_ethdev.h | 4 +++-
> >  drivers/net/octeontx2/otx2_rss.c    | 9 +++++++--
> >  2 files changed, 10 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/octeontx2/otx2_ethdev.h
> > b/drivers/net/octeontx2/otx2_ethdev.h
> > index e9efe52bb..953445ecb 100644
> > --- a/drivers/net/octeontx2/otx2_ethdev.h
> > +++ b/drivers/net/octeontx2/otx2_ethdev.h
> > @@ -119,7 +119,9 @@
> >  #define NIX_RSS_OFFLOAD                (ETH_RSS_PORT | ETH_RSS_IP |
> ETH_RSS_UDP |\
> >                                  ETH_RSS_TCP | ETH_RSS_SCTP | \
> >                                  ETH_RSS_TUNNEL | ETH_RSS_L2_PAYLOAD | \
> > -                                NIX_RSS_L3_L4_SRC_DST)
> > +                                NIX_RSS_L3_L4_SRC_DST | 
> > ETH_RSS_LEVEL_INNER | \
> > +                                ETH_RSS_LEVEL_OUTER | \
> > +                                ETH_RSS_LEVEL_INNER_OUTER)
> 
> Since it is value 1 and 2, for bitmask purpose, shouldn't be
> ETH_RSS_LEVEL_MASK  instead of ETH_RSS_LEVEL_OUTER |
> ETH_RSS_LEVEL_INNER_OUTER


Will update in V4.

Reply via email to