[dpdk-dev] [RFC 09/16] testpmd: move csum_show in a function

[Olivier MATZ]

Hi Jijiang,

On 01/23/2015 12:03 PM, Liu, Jijiang wrote:
> +     /* display warnings if configuration is not supported by the NIC */
> +     rte_eth_dev_info_get(port_id, &dev_info);
> +     if ((ol_flags & TESTPMD_TX_OFFLOAD_IP_CKSUM) &&
> +             (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_IPV4_CKSUM) == 0) {
> +             printf("Warning: hardware IP checksum enabled but not "
> +                     "supported by port %d\n", port_id);
> +     }
> +     if ((ol_flags & TESTPMD_TX_OFFLOAD_UDP_CKSUM) &&
> +             (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_UDP_CKSUM) == 0) {
> +             printf("Warning: hardware UDP checksum enabled but not "
> +                     "supported by port %d\n", port_id);
> +     }
> +     if ((ol_flags & TESTPMD_TX_OFFLOAD_TCP_CKSUM) &&
> +             (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_TCP_CKSUM) == 0) {
> +             printf("Warning: hardware TCP checksum enabled but not "
> +                     "supported by port %d\n", port_id);
> +     }
> +     if ((ol_flags & TESTPMD_TX_OFFLOAD_SCTP_CKSUM) &&
> +             (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_SCTP_CKSUM) == 0) {
> +             printf("Warning: hardware SCTP checksum enabled but not "
> +                     "supported by port %d\n", port_id);
> +     }
> 
> The ESTPMD_TX_OFFLOAD_OUTER_IP_CKSUM  check is missed  here.

Yes, it should be added in this patch:
  ethdev: add outer IP offload capability flag

I'll do it for the next version.

Regards,
Olivier