> -----Original Message----- > From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, August 6, 2020 9:20 PM > To: wangyunjian <wangyunj...@huawei.com> > Cc: dev@dpdk.org; sta...@dpdk.org; keith.wi...@intel.com; > ophi...@mellanox.com; Lilijun (Jerry) <jerry.lili...@huawei.com>; xudingke > <xudin...@huawei.com>; sta...@dpdk.org > Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/tap: free mempool when > closing > > 06/08/2020 14:47, wangyunjian: > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > 29/07/2020 13:35, wangyunjian: > > > > From: Yunjian Wang <wangyunj...@huawei.com> > > > > > > > > When setup tx queues, we will create a mempool for the 'gso_ctx'. > > > > The mempool is not freed when closing tap device. If free the tap > > > > device and create it with different name, it will create a new > > > > mempool. This maybe cause an OOM. > > > > > > While at it, please look at implementing RTE_ETH_DEV_CLOSE_REMOVE > > > behaviour in tap. Thanks > > > > > > > I read the codes about tap device. Currently, the tap pmd doesn't use > > RTE_ETH_DEV_CLOSE_REMOVE flag. > > I know. That's why I suggest to switch to RTE_ETH_DEV_CLOSE_REMOVE. > Please see this deprecation notice: > http://git.dpdk.org/dpdk/commit/?id=7efbaa7b4e423
OK, I have sent a patch to add this feature for tap device. https://patchwork.dpdk.org/patch/76137/ Thanks, Yunjian >
