Hi Arek, Thank you very much to review.
> -----Original Message----- > From: Kusztal, ArkadiuszX <[email protected]> > Sent: Monday, August 31, 2020 7:24 AM > To: Zhang, Roy Fan <[email protected]>; [email protected] > Cc: [email protected]; Trahe, Fiona <[email protected]>; Dybkowski, > AdamX <[email protected]>; Bronowski, PiotrX > <[email protected]> > Subject: RE: [dpdk-dev v7 1/4] cryptodev: add crypto data-path service APIs > > > [Arek] - Two small things: > - rte_crypto_data - there is many thing in asymmetric/symmetric > crypto that can be called like that, and this is basically symmetric > encrypted/authenticated data pointer, maybe some more specific name > could be better. [Fan] Any good name to propose? > - can iv, digest, aad be grouped into one? All share the same features, > and there would less arguments to functions. > -- > 2.20.1 Something like struct rte_crypto_sym_<GOOD_NAME_HERE> { void * iv, *digest, *aad; rte_iova_t iv_iova, digest_iova, aad_iova; }; ? Definitely can do. Regards, Fan
