> -----Original Message----- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Sunday, January 25, 2015 4:05 PM > To: Liang, Cunming > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v1 09/15] malloc: fix the issue of > SOCKET_ID_ANY > > On Thu, 22 Jan 2015 16:16:32 +0800 > Cunming Liang <cunming.liang at intel.com> wrote: > > > - return rte_socket_id(); > > + unsigned socket_id = rte_socket_id(); > > + > > + if (socket_id == (unsigned)SOCKET_ID_ANY) > > I prefer not casting -1 to unsigned it will cause warnings. > It is better to make socket_id an integer and then have > the implicit cast in the return. [Liang, Cunming] I didn't got warning about it, in which version of compiler complain it ?
- [dpdk-dev] [PATCH v1 02/15] eal: new ea... Bruce Richardson
- [dpdk-dev] [PATCH v1 02/15] eal: new eal op... Liang, Cunming
- [dpdk-dev] [PATCH v1 03/15] eal: add support parsing... Cunming Liang
- [dpdk-dev] [PATCH v1 04/15] eal: new TLS definition ... Cunming Liang
- [dpdk-dev] [PATCH v1 05/15] eal: add eal_common_thre... Cunming Liang
- [dpdk-dev] [PATCH v1 06/15] eal: add rte_gettid() to... Cunming Liang
- [dpdk-dev] [PATCH v1 07/15] eal: apply affinity of E... Cunming Liang
- [dpdk-dev] [PATCH v1 08/15] enic: fix re-define free... Cunming Liang
- [dpdk-dev] [PATCH v1 09/15] malloc: fix the issue of... Cunming Liang
- [dpdk-dev] [PATCH v1 09/15] malloc: fix the iss... Stephen Hemminger
- [dpdk-dev] [PATCH v1 09/15] malloc: fix the... Liang, Cunming
- [dpdk-dev] [PATCH v1 09/15] malloc: fix the iss... Stephen Hemminger
- [dpdk-dev] [PATCH v1 10/15] log: fix the gap to supp... Cunming Liang
- [dpdk-dev] [PATCH v1 11/15] eal: set _lcore_id and _... Cunming Liang
- [dpdk-dev] [PATCH v1 12/15] eal: fix recursive spinl... Cunming Liang
- [dpdk-dev] [PATCH v1 13/15] mempool: add support to ... Cunming Liang
- [dpdk-dev] [PATCH v1 13/15] mempool: add suppor... Walukiewicz, Miroslaw
- [dpdk-dev] [PATCH v1 13/15] mempool: add su... Liang, Cunming
- [dpdk-dev] [PATCH v1 13/15] mempool: ad... Walukiewicz, Miroslaw
- [dpdk-dev] [PATCH v1 13/15] mempool... Ananyev, Konstantin
- [dpdk-dev] [PATCH v1 14/15] ring: add support to non... Cunming Liang