On 9/1/2020 12:44 PM, Ferruh Yigit wrote: > On 8/8/2020 8:45 AM, liqingqing wrote: >> fix coredump when secondary process using the hinic port. >> the reason is that during the stage of >> secondary process port initialization, >> it lack the initialization of "eth_dev->dev_ops". >> >> Signed-off-by: liqingqing <liqingqi...@huawei.com> > > Hi, > > Overall patch looks good but can you please add your name and surname to the > sign off, to make it following syntax: > Signed-off-by: Name Surname <liqingqi...@huawei.com> > > Also what do you think about following patch title: > "net/hinic: fix crash in secondary process" >
Hi Ziyang, Xiaoyun, Guoyang, Can you please review the patch, also can you please help on getting the correct sign off?