Hello Conor, On Mon, Sep 14, 2020 at 2:54 PM Conor Walsh <conor.wa...@intel.com> wrote: > > Since librte_ipsec was first introduced in 19.02 and there were no changes > in it's public API since 19.11, it should be considered mature enough to > remove the 'experimental' tag from it. > The RTE_SATP_LOG2_NUM enum is also being dropped from rte_ipsec_sa.h to > avoid possible ABI problems in the future. > > --- > v2: RTE_SATP_LOG2_NUM dropped from enum
Small comments that I guess could be fixed while applying. Commit title prefixes don't start with lib/. > > Signed-off-by: Conor Walsh <conor.wa...@intel.com> > --- > MAINTAINERS | 2 +- > doc/guides/rel_notes/release_20_11.rst | 1 + > lib/librte_ipsec/rte_ipsec.h | 8 -------- > lib/librte_ipsec/rte_ipsec_group.h | 3 --- > lib/librte_ipsec/rte_ipsec_sa.h | 8 +------- > lib/librte_ipsec/rte_ipsec_sad.h | 7 ------- > lib/librte_ipsec/rte_ipsec_version.map | 2 +- > 7 files changed, 4 insertions(+), 27 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index ed163f5d5..f66772908 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -1286,7 +1286,7 @@ M: Jiayu Hu <jiayu...@intel.com> > F: lib/librte_gso/ > F: doc/guides/prog_guide/generic_segmentation_offload_lib.rst > > -IPsec - EXPERIMENTAL > +IPsec > M: Konstantin Ananyev <konstantin.anan...@intel.com> > T: git://dpdk.org/next/dpdk-next-crypto > F: lib/librte_ipsec/ > diff --git a/doc/guides/rel_notes/release_20_11.rst > b/doc/guides/rel_notes/release_20_11.rst > index df227a177..b750fcf65 100644 > --- a/doc/guides/rel_notes/release_20_11.rst > +++ b/doc/guides/rel_notes/release_20_11.rst > @@ -100,6 +100,7 @@ ABI Changes > Also, make sure to start the actual text at the margin. > ======================================================= > > +* ipsec: ``RTE_SATP_LOG2_NUM`` has been dropped from ``enum`` There is no ABI compat in this release, and this is an API change. Documentation blocks are separated with double empty lines (like it was before your patch). > > Known Issues > ------------ -- David Marchand
