On 8/31/20 9:59 AM, Eugenio Pérez wrote:
> Bugzilla bug: 523
>
> Control thread (which handles iotlb msg) and forwarding
> thread both use iotlb to translate address. The former may modify the
> same entry of mempool and may cause a loop in iotlb_pending_entries
> list.
Bugzilla ID: 523
> Fixes: d012d1f293f4 ("vhost: add IOTLB helper functions")
> Signed-off-by: Eugenio Pérez <epere...@redhat.com>
> ---
> lib/librte_vhost/iotlb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/lib/librte_vhost/iotlb.c b/lib/librte_vhost/iotlb.c
> index 5b3a0c090..e0b67721b 100644
> --- a/lib/librte_vhost/iotlb.c
> +++ b/lib/librte_vhost/iotlb.c
> @@ -321,8 +321,7 @@ vhost_user_iotlb_init(struct virtio_net *dev, int
> vq_index)
> IOTLB_CACHE_SIZE, sizeof(struct vhost_iotlb_entry), 0,
> 0, 0, NULL, NULL, NULL, socket,
> MEMPOOL_F_NO_CACHE_ALIGN |
> - MEMPOOL_F_SP_PUT |
> - MEMPOOL_F_SC_GET);
> + MEMPOOL_F_SP_PUT);
> if (!vq->iotlb_pool) {
> VHOST_LOG_CONFIG(ERR,
> "Failed to create IOTLB cache pool (%s)\n",
>
I'll fix commit message while applying.
Thanks for your contribution:
Reviewed-by: Maxime Coquelin <maxime.coque...@redhat.com>
Maxime