Hi Akhil, Please see inline.
Thanks Tejasree > -----Original Message----- > From: Akhil Goyal <[email protected]> > Sent: Friday, September 11, 2020 12:39 AM > To: Tejasree Kondoj <[email protected]>; Radu Nicolau > <[email protected]> > Cc: Narayana Prasad Raju Athreya <[email protected]>; Anoob Joseph > <[email protected]>; [email protected] > Subject: [EXT] RE: [PATCH] security: allow application to specify UDP ports to > PMD > > External Email > > ---------------------------------------------------------------------- > Hi Tejasree, > > > Add UDP source and destination ports in ipsec_xform to allow > > application to specify ports to be used for IPsec UDP encapsulation as > > they are dynamically changed by NAT in between. Also adding an extra > > flag to indicate whether PMD needs to perform encapsulation header > > verification in case of inbound. In case of inline IPsec > > implementation, verification of outer IP headers and UDP encapsulation > > headers need to be handled in the PMD. For lookaside IPsec, > > application can optionally offload this to the PMD. > > > > Signed-off-by: Tejasree Kondoj <[email protected]> > > --- > > I think we should add some usage of these newly added params > - either in app/test or in examples/ipsec-secgw [Tejasree] You mean adding test case in either of the above apps or addition of PMD implementation also? Also is the proposal sounds fine? > > Regards, > Akhil
