> -----Original Message----- > From: Steven Lariau <[email protected]> > Sent: Friday, September 11, 2020 10:30 AM > To: Eads, Gage <[email protected]>; Olivier Matz <[email protected]> > Cc: [email protected]; [email protected]; [email protected]; Steven Lariau > <[email protected]> > Subject: [PATCH 1/5] lib/stack: fix inconsistent weak / strong cas > > Fix cmpexchange usage of weak / strong. > The generated code is the same on x86 and ARM (there is no weak > cmpexchange), but the old usage was inconsistent. > For push and pop update size, weak is used because cmpexchange is inside > a loop. > For pop update root, strong is used even though cmpexchange is inside a > loop, because there may be a lot of operations to do in a loop iteration > (locate the new head). > > Signed-off-by: Steven Lariau <[email protected]> > Reviewed-by: Dharmik Thakkar <[email protected]> > Reviewed-by: Ruifeng Wang <[email protected]> Acked-by: Gage Eads <[email protected]> Thanks, Gage
