On Thu, Jan 29, 2015 at 11:52:03PM +0000, Liang, Cunming wrote: > > > > -----Original Message----- > > From: Richardson, Bruce > > Sent: Thursday, January 29, 2015 4:30 PM > > To: Zhang, Helin > > Cc: dev at dpdk.org; Cao, Waterman; Liang, Cunming; Liu, Jijiang; Ananyev, > > Konstantin > > Subject: Re: [PATCH 04/17] ixgbe: support of unified packet type > > > > On Thu, Jan 29, 2015 at 11:15:52AM +0800, Helin Zhang wrote: > > > To unify packet types among all PMDs, bit masks of packet type for > > > ol_flags are replaced by unified packet type for Vector PMD. > > > > > > > Two suggestions on the commit log: > > 1. Can you add scalar and vector into the titles to make it clear how this > > patch and the previous ones differ > > 2. Can you add a note calling out performance impacts for this patch. If no > > performance impacts, then please note that for reviewers. > [Liang, Cunming] Accept, will update it in v2. > For performance, lose 1 cycle per packet during 4x10GE io fwd loopback unit > test. > Good to know, thanks.
/Bruce