Hi, > -----Original Message----- > From: Thomas Monjalon <[email protected]> > Sent: Monday, September 28, 2020 7:42 > To: [email protected] > Cc: Yigit, Ferruh <[email protected]>; [email protected]; John > W. Linville <[email protected]>; Loftus, Ciara <[email protected]>; > Zhang, Qi Z <[email protected]>; Shepard Siegel > <[email protected]>; Ed Czeck <[email protected]>; > John Miller <[email protected]>; Igor Russkikh > <[email protected]>; Pavel Belous <[email protected]>; > Steven Webster <[email protected]>; Matt Peters > <[email protected]>; Somalapuram Amaranath > <[email protected]>; Rasesh Mody <[email protected]>; Shahed > Shaikh <[email protected]>; Ajit Khaparde > <[email protected]>; Somnath Kotur > <[email protected]>; Chas Williams <[email protected]>; Wei Hu > (Xavier) <[email protected]>; Rahul Lakkireddy > <[email protected]>; Hemant Agrawal > <[email protected]>; Sachin Saxena <[email protected]>; > Guo, Jia <[email protected]>; Wang, Haiyue <[email protected]>; > Marcin Wojtas <[email protected]>; Michal Krawczyk <[email protected]>; > Guy Tzalik <[email protected]>; Evgeny Schemeilin > <[email protected]>; Igor Chauskin <[email protected]>; > Gagandeep Singh <[email protected]>; John Daley <[email protected]>; > Hyong Youb Kim <[email protected]>; Gaetan Rivet <[email protected]>; > Wang, Xiao W <[email protected]>; Ziyang Xuan > <[email protected]>; Xiaoyun Wang > <[email protected]>; Guoyang Zhou > <[email protected]>; Min Hu (Connor) <[email protected]>; > Yisen Zhuang <[email protected]>; Xing, Beilei > <[email protected]>; Wu, Jingjing <[email protected]>; Yang, Qiming > <[email protected]>; Alfredo Cardigliano <[email protected]>; Xu, > Rosen <[email protected]>; Shijith Thotton <[email protected]>; > Srisivasubramanian Srinivasan <[email protected]>; Jakub Grajciar > <[email protected]>; Matan Azrad <[email protected]>; Shahaf Shuler > <[email protected]>; Viacheslav Ovsiienko <[email protected]>; > Zyta Szpak <[email protected]>; Liron Himi <[email protected]>; Stephen > Hemminger <[email protected]>; K. Y. Srinivasan > <[email protected]>; Haiyang Zhang <[email protected]>; Long Li > <[email protected]>; Martin Spinler <[email protected]>; Heinrich Kuhn > <[email protected]>; Harman Kalra <[email protected]>; > Jerin Jacob <[email protected]>; Nithin Dabilpuram > <[email protected]>; Kiran Kumar K <[email protected]>; > Akhil Goyal <[email protected]>; Singh, Jasvinder > <[email protected]>; Dumitrescu, Cristian > <[email protected]>; Wiles, Keith <[email protected]>; > Maciej Czekaj <[email protected]>; Maxime Coquelin > <[email protected]>; Xia, Chenbo <[email protected]>; > Wang, Zhihong <[email protected]>; Yong Wang > <[email protected]> > Subject: [PATCH v2 02/25] ethdev: allow drivers to return error on close > > The device operation .dev_close was returning void. > This driver interface is changed to return an int. > > Note that the API rte_eth_dev_close() is still returning void, > although a deprecation notice is pending to change it as well. > > Signed-off-by: Thomas Monjalon <[email protected]> > --- > app/test/virtual_pmd.c | 6 ++++-- > drivers/net/af_packet/rte_eth_af_packet.c | 3 ++- > drivers/net/af_xdp/rte_eth_af_xdp.c | 4 +++- > drivers/net/ark/ark_ethdev.c | 6 ++++-- > drivers/net/atlantic/atl_ethdev.c | 6 ++++-- > drivers/net/avp/avp_ethdev.c | 5 +++-- > drivers/net/axgbe/axgbe_ethdev.c | 5 +++-- > drivers/net/bnx2x/bnx2x_ethdev.c | 4 +++- > drivers/net/bnxt/bnxt_ethdev.c | 4 +++- > drivers/net/bnxt/bnxt_reps.c | 3 ++- > drivers/net/bnxt/bnxt_reps.h | 2 +- > drivers/net/bonding/eth_bond_private.h | 2 +- > drivers/net/bonding/rte_eth_bond_pmd.c | 4 +++- > drivers/net/cxgbe/cxgbe_ethdev.c | 10 ++++++---- > drivers/net/cxgbe/cxgbe_pfvf.h | 2 +- > drivers/net/dpaa/dpaa_ethdev.c | 4 +++- > drivers/net/dpaa2/dpaa2_ethdev.c | 6 ++++-- > drivers/net/e1000/em_ethdev.c | 6 ++++-- > drivers/net/e1000/igb_ethdev.c | 12 ++++++++---- > drivers/net/ena/ena_ethdev.c | 6 ++++-- > drivers/net/enetc/enetc_ethdev.c | 4 +++- > drivers/net/enic/enic_ethdev.c | 4 +++- > drivers/net/enic/enic_vf_representor.c | 5 +++-- > drivers/net/failsafe/failsafe_ops.c | 3 ++- > drivers/net/fm10k/fm10k_ethdev.c | 4 +++- > drivers/net/hinic/hinic_pmd_ethdev.c | 6 ++++-- > drivers/net/hns3/hns3_ethdev.c | 6 ++++-- > drivers/net/hns3/hns3_ethdev_vf.c | 6 ++++-- > drivers/net/i40e/i40e_ethdev.c | 5 +++-- > drivers/net/i40e/i40e_ethdev_vf.c | 5 +++-- > drivers/net/iavf/iavf_ethdev.c | 6 ++++-- > drivers/net/ice/ice_dcf_ethdev.c | 6 ++++-- > drivers/net/ice/ice_ethdev.c | 6 ++++-- > drivers/net/igc/igc_ethdev.c | 6 ++++-- > drivers/net/ionic/ionic_ethdev.c | 10 ++++++---- > drivers/net/ipn3ke/ipn3ke_representor.c | 4 +++- > drivers/net/ixgbe/ixgbe_ethdev.c | 11 +++++++---- > drivers/net/kni/rte_eth_kni.c | 4 +++- > drivers/net/liquidio/lio_ethdev.c | 4 +++- > drivers/net/memif/rte_eth_memif.c | 4 +++- > drivers/net/mlx4/mlx4.c | 3 ++- > drivers/net/mlx5/mlx5.c | 9 +++++---- > drivers/net/mlx5/mlx5.h | 2 +- > drivers/net/mvneta/mvneta_ethdev.c | 4 +++- > drivers/net/mvpp2/mrvl_ethdev.c | 4 +++- > drivers/net/netvsc/hn_ethdev.c | 4 +++- > drivers/net/nfb/nfb_ethdev.c | 4 +++- > drivers/net/nfp/nfp_net.c | 6 ++++-- > drivers/net/octeontx/octeontx_ethdev.c | 4 +++- > drivers/net/octeontx2/otx2_ethdev.c | 5 +++-- > drivers/net/pcap/rte_eth_pcap.c | 3 ++- > drivers/net/pfe/pfe_ethdev.c | 8 +++++--- > drivers/net/qede/qede_ethdev.c | 4 +++- > drivers/net/sfc/sfc_ethdev.c | 4 +++- > drivers/net/softnic/rte_eth_softnic.c | 4 ++-- > drivers/net/szedata2/rte_eth_szedata2.c | 4 +++- > drivers/net/tap/rte_eth_tap.c | 4 +++- > drivers/net/thunderx/nicvf_ethdev.c | 4 +++- > drivers/net/vhost/rte_eth_vhost.c | 6 ++++-- > drivers/net/virtio/virtio_ethdev.c | 6 ++++-- > drivers/net/vmxnet3/vmxnet3_ethdev.c | 6 ++++-- > lib/librte_ethdev/rte_ethdev_driver.h | 2 +- > 62 files changed, 206 insertions(+), 103 deletions(-) > > static int > diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c > b/drivers/net/ipn3ke/ipn3ke_representor.c > index b673c49149..d49abbf758 100644 > --- a/drivers/net/ipn3ke/ipn3ke_representor.c > +++ b/drivers/net/ipn3ke/ipn3ke_representor.c > @@ -208,7 +208,7 @@ ipn3ke_rpst_dev_stop(struct rte_eth_dev *dev) > } > } > > -static void > +static int > ipn3ke_rpst_dev_close(struct rte_eth_dev *dev) > { > struct ipn3ke_hw *hw = IPN3KE_DEV_PRIVATE_TO_HW(dev); > @@ -221,6 +221,8 @@ ipn3ke_rpst_dev_close(struct rte_eth_dev *dev) > /* Disable the RX path */ > ipn3ke_xmac_rx_disable(hw, rpst->port_id, 0); > } > + > + return 0; > } > > /* > 2.28.0
For net/ipn3ke Reviewed-by: Rosen Xu <[email protected]>
