Hi, > -----Original Message----- > From: Thomas Monjalon <[email protected]> > Sent: Monday, September 28, 2020 7:43 > To: [email protected] > Cc: Yigit, Ferruh <[email protected]>; [email protected]; > Loftus, Ciara <[email protected]>; Zhang, Qi Z <[email protected]>; > Shepard Siegel <[email protected]>; Ed Czeck > <[email protected]>; John Miller <[email protected]>; > Steven Webster <[email protected]>; Matt Peters > <[email protected]>; Ajit Khaparde > <[email protected]>; Somnath Kotur > <[email protected]>; Rahul Lakkireddy > <[email protected]>; Hemant Agrawal > <[email protected]>; Sachin Saxena <[email protected]>; > Guo, Jia <[email protected]>; Wang, Haiyue <[email protected]>; > Marcin Wojtas <[email protected]>; Michal Krawczyk <[email protected]>; > Guy Tzalik <[email protected]>; Evgeny Schemeilin > <[email protected]>; Igor Chauskin <[email protected]>; > Gagandeep Singh <[email protected]>; John Daley <[email protected]>; > Hyong Youb Kim <[email protected]>; Wang, Xiao W > <[email protected]>; Ziyang Xuan <[email protected]>; > Xiaoyun Wang <[email protected]>; Guoyang Zhou > <[email protected]>; Xing, Beilei <[email protected]>; Wu, > Jingjing <[email protected]>; Yang, Qiming <[email protected]>; > Alfredo Cardigliano <[email protected]>; Xu, Rosen > <[email protected]>; Shijith Thotton <[email protected]>; > Srisivasubramanian Srinivasan <[email protected]>; Matan Azrad > <[email protected]>; Shahaf Shuler <[email protected]>; Zyta Szpak > <[email protected]>; Liron Himi <[email protected]>; Stephen Hemminger > <[email protected]>; K. Y. Srinivasan <[email protected]>; > Haiyang Zhang <[email protected]>; Long Li <[email protected]>; > Martin Spinler <[email protected]>; Heinrich Kuhn > <[email protected]>; Harman Kalra <[email protected]>; > Akhil Goyal <[email protected]>; Jerin Jacob <[email protected]>; > Maciej Czekaj <[email protected]>; Maxime Coquelin > <[email protected]>; Xia, Chenbo <[email protected]>; > Wang, Zhihong <[email protected]>; Yong Wang > <[email protected]>; Burakov, Anatoly <[email protected]> > Subject: [PATCH v2 19/25] drivers/net: check process type in close operation > > The secondary processes are not allowed to release shared resources. > Only process-private ressources should be freed in a secondary process. > Most of the time, there is no process-private ressource, so the close > operation is just forbidden in a secondary process. > > After adding proper check in the port close functions, some redundant > checks in the device remove functions are dropped. > > Signed-off-by: Thomas Monjalon <[email protected]> > --- > drivers/net/af_xdp/rte_eth_af_xdp.c | 3 +++ > drivers/net/ark/ark_ethdev.c | 3 +++ > drivers/net/avp/avp_ethdev.c | 3 +++ > drivers/net/bnxt/bnxt_ethdev.c | 3 +++ > drivers/net/bnxt/bnxt_reps.c | 3 +++ > drivers/net/cxgbe/cxgbe_ethdev.c | 3 +++ > drivers/net/dpaa/dpaa_ethdev.c | 3 +++ > drivers/net/dpaa2/dpaa2_ethdev.c | 3 +++ > drivers/net/e1000/em_ethdev.c | 3 +++ > drivers/net/e1000/igb_ethdev.c | 6 +++++ > drivers/net/ena/ena_ethdev.c | 3 +++ > drivers/net/enetc/enetc_ethdev.c | 3 +++ > drivers/net/enic/enic_ethdev.c | 3 +++ > drivers/net/fm10k/fm10k_ethdev.c | 9 ++----- > drivers/net/hinic/hinic_pmd_ethdev.c | 3 +++ > drivers/net/i40e/i40e_ethdev.c | 2 ++ > drivers/net/i40e/i40e_ethdev_vf.c | 3 +++ > drivers/net/iavf/iavf_ethdev.c | 3 +++ > drivers/net/ice/ice_ethdev.c | 3 +++ > drivers/net/igc/igc_ethdev.c | 6 ++--- > drivers/net/ionic/ionic_ethdev.c | 2 ++ > drivers/net/ipn3ke/ipn3ke_representor.c | 3 +++ > drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++++ > drivers/net/kni/rte_eth_kni.c | 3 +++ > drivers/net/liquidio/lio_ethdev.c | 3 +++ > drivers/net/mlx4/mlx4.c | 2 ++ > drivers/net/mvneta/mvneta_ethdev.c | 3 +++ > drivers/net/mvpp2/mrvl_ethdev.c | 3 +++ > drivers/net/netvsc/hn_ethdev.c | 2 ++ > drivers/net/nfb/nfb_ethdev.c | 3 +++ > drivers/net/nfp/nfp_net.c | 3 +++ > drivers/net/octeontx/octeontx_ethdev.c | 2 ++ > drivers/net/pfe/pfe_ethdev.c | 3 +++ > drivers/net/sfc/sfc_ethdev.c | 32 ++++++++++++------------- > drivers/net/szedata2/rte_eth_szedata2.c | 3 +++ > drivers/net/thunderx/nicvf_ethdev.c | 7 +++--- > drivers/net/vhost/rte_eth_vhost.c | 7 +++--- > drivers/net/virtio/virtio_ethdev.c | 2 ++ > drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 ++ > 39 files changed, 125 insertions(+), 35 deletions(-) > > diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c > b/drivers/net/ipn3ke/ipn3ke_representor.c > index d49abbf758..b9fb4d4e46 100644 > --- a/drivers/net/ipn3ke/ipn3ke_representor.c > +++ b/drivers/net/ipn3ke/ipn3ke_representor.c > @@ -214,6 +214,9 @@ ipn3ke_rpst_dev_close(struct rte_eth_dev *dev) > struct ipn3ke_hw *hw = IPN3KE_DEV_PRIVATE_TO_HW(dev); > struct ipn3ke_rpst *rpst = IPN3KE_DEV_PRIVATE_TO_RPST(dev); > > + if (rte_eal_process_type() != RTE_PROC_PRIMARY) > + return 0; > + > if (hw->retimer.mac_type == > IFPGA_RAWDEV_RETIMER_MAC_TYPE_10GE_XFI) { > /* Disable the TX path */ > ipn3ke_xmac_tx_disable(hw, rpst->port_id, 0); diff --git > 2.28.0
For net/ipn3ke Reviewed-by: Rosen Xu <[email protected]>
