[dpdk-dev] [PATCH v2] net/ring: fix unchecked return value

[Kevin Laatz]

Add a check for the return value of the sscanf call in
parse_internal_args(), returning an error if we don't get the expected
result.

Coverity issue: 362049
Fixes: 96cb19521147 ("net/ring: use EAL APIs in PMD specific API")
Cc: sta...@dpdk.org

Signed-off-by: Kevin Laatz <kevin.la...@intel.com>

---
v2: added consumed characters count check
---
 drivers/net/ring/rte_eth_ring.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c
index 40fe1ca4ba..66367465fd 100644
--- a/drivers/net/ring/rte_eth_ring.c
+++ b/drivers/net/ring/rte_eth_ring.c
@@ -538,8 +538,13 @@ parse_internal_args(const char *key __rte_unused, const 
char *value,
 {
        struct ring_internal_args **internal_args = data;
        void *args;
+       int n;
 
-       sscanf(value, "%p", &args);
+       if (sscanf(value, "%p%n", &args, &n) != 1 || (size_t)n != 
strlen(value)) {
+               PMD_LOG(ERR, "Error parsing internal args");
+
+               return -1;
+       }
 
        *internal_args = args;
 
-- 
2.25.1