>-----Original Message----- >From: dev <[email protected]> On Behalf Of David Marchand >Sent: Thursday, September 24, 2020 12:31 PM >To: Ferruh Yigit <[email protected]> >Cc: Wenzhuo Lu <[email protected]>; Beilei Xing ><[email protected]>; Bernard Iremonger ><[email protected]>; dev <[email protected]>; NBU-Contact-Adrien >Mazarguil <[email protected]> >Subject: Re: [dpdk-dev] [PATCH 3/4] app/testpmd: fix build with gcc 11 > >On Mon, Sep 21, 2020 at 3:39 PM Ferruh Yigit <[email protected]> wrote: >> >> Error observed with gcc 11 under development gcc (GCC) 11.0.0 20200920 >> (experimental) >> >> ../app/test-pmd/config.c:1777:61: >> warning: argument 3 of type ‘const uint32_t[n]’ >> {aka ‘const unsigned int[n]’} declared as a variable length >> array [-Wvla-parameter] >> 1777 | port_flow_list(portid_t port_id, uint32_t n, >> const uint32_t group[n]) >> | ~~~~~~~~~~~~~~~^~~~~~~~ >> In file included from ../app/test-pmd/config.c:53: >> ../app/test-pmd/testpmd.h:764:67: >> note: previously declared as a pointer ‘const uint32_t *’ >> {aka ‘const unsigned int *’} >> 764 | void port_flow_list(portid_t port_id, uint32_t n, >> const uint32_t *group); >> | ~~~~~~~~~~~~~~~~^~~~~ >> > >It won't hurt to backport this. > >Fixes: 938a184a1870 ("app/testpmd: implement basic support for flow API") >Cc: [email protected] > >> Signed-off-by: Ferruh Yigit <[email protected]> >> --- >> app/test-pmd/config.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index >> b6eb2a57a..380f3b5f6 100644 >> --- a/app/test-pmd/config.c >> +++ b/app/test-pmd/config.c >> @@ -1774,7 +1774,7 @@ port_flow_aged(portid_t port_id, uint8_t >> destroy) >> >> /** List flow rules. */ >> void >> -port_flow_list(portid_t port_id, uint32_t n, const uint32_t group[n]) >> +port_flow_list(portid_t port_id, uint32_t n, const uint32_t *group) >> { >> struct rte_port *port; >> struct port_flow *pf; >> -- >> 2.26.2 >> > >Reviewed-by: David Marchand <[email protected]> > >-- >David Marchand
Reviewed-by: Asaf Penso <[email protected]>
