On Sun, Oct 4, 2020 at 4:23 PM Nipun Gupta <[email protected]> wrote: > > Acked-by: Nipun Gupta <[email protected]>
Applied to dpdk-next-eventdev/for-main. Thanks. > > > -----Original Message----- > > From: wangyunjian <[email protected]> > > Sent: Wednesday, August 26, 2020 6:38 PM > > To: [email protected]; Hemant Agrawal <[email protected]>; Nipun Gupta > > <[email protected]> > > Cc: [email protected]; [email protected]; Yunjian Wang > > <[email protected]>; [email protected] > > Subject: [dpdk-dev] [PATCH] event/dpaa2: fix dereference before null check > > > > From: Yunjian Wang <[email protected]> > > > > Coverity flags that 'portal' variable is used before > > it's checked for NULL. This patch fixes this issue. > > > > Coverity issue: 323516 > > Fixes: 4ab57b042e7c ("event/dpaa2: affine portal at runtime during I/O") > > Cc: [email protected] > > > > Signed-off-by: Yunjian Wang <[email protected]> > > --- > > drivers/event/dpaa2/dpaa2_eventdev.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c > > b/drivers/event/dpaa2/dpaa2_eventdev.c > > index 3ae4441ee..f7383ca73 100644 > > --- a/drivers/event/dpaa2/dpaa2_eventdev.c > > +++ b/drivers/event/dpaa2/dpaa2_eventdev.c > > @@ -569,14 +569,14 @@ dpaa2_eventdev_port_release(void *port) > > > > EVENTDEV_INIT_FUNC_TRACE(); > > > > + if (portal == NULL) > > + return; > > + > > /* TODO: Cleanup is required when ports are in linked state. */ > > if (portal->is_port_linked) > > DPAA2_EVENTDEV_WARN("Event port must be unlinked before > > release"); > > > > - if (portal) > > - rte_free(portal); > > - > > - portal = NULL; > > + rte_free(portal); > > } > > > > static int > > -- > > 2.23.0 > > >
