> The channel commands header file contains definitions that are used by the
> example application for power management, and so need to be made public.
> Similarly the guest_channel.h header is used by the guest_cli example
> utility, so needs to be public also.  Without this change, the example
> apps, or any end-user apps based on them, can not be compiled outside the
> main DPDK build.
[...]
>  rename lib/librte_power/{channel_commands.h => rte_power_channel_commands.h} 
> (100%)
>  rename lib/librte_power/{guest_channel.h => rte_power_guest_channel.h} (98%)

Yes there are dirty includes, but it requires more than just a renaming.
At least the namespace of these functions should be checked
to start with "rte_".
But before adding all these new functions as stable public API,
I would like we check whether it is a well designed API or not.

Reply via email to