> -----Original Message----- > From: McDaniel, Timothy <[email protected]> > Sent: Monday, October 5, 2020 9:28 PM > To: Hemant Agrawal <[email protected]>; Nipun Gupta > <[email protected]>; Mattias Rönnblom <[email protected]>; > Jerin Jacob <[email protected]>; Pavan Nikhilesh <[email protected]>; > Ma, Liang J <[email protected]>; Mccarthy, Peter > <[email protected]>; > Van Haaren, Harry <[email protected]>; Rao, Nikhil > <[email protected]>; Ray Kinsella <[email protected]>; Neil Horman > <[email protected]> > Cc: [email protected]; Carrillo, Erik G <[email protected]>; Eads, Gage > <[email protected]> > Subject: [PATCH v2 1/2] eventdev: eventdev: express DLB/DLB2 PMD constraints > > This commit implements the eventdev ABI changes required by > the DLB PMD. > > Signed-off-by: Timothy McDaniel <[email protected]> > ---
I think patches 1/2 and 2/2 will have to be merged into a single patch. Reason is that compilation fails after 1/2 because apps/examples access the "disable_implicit_release" field, which is refactored in 1/2. For review, this split is quite convenient for reviewing - so suggesting we can merge on apply if no changes are required? <snip> > drivers/event/sw/sw_evdev.c | 8 ++-- > drivers/event/sw/sw_evdev_selftest.c | 6 +-- For SW PMD component and selftests; Acked-by: Harry van Haaren <[email protected]> > static void > diff --git a/drivers/event/sw/sw_evdev.c b/drivers/event/sw/sw_evdev.c > index 98dae71..058f568 100644 > --- a/drivers/event/sw/sw_evdev.c > +++ b/drivers/event/sw/sw_evdev.c > @@ -175,7 +175,8 @@ sw_port_setup(struct rte_eventdev *dev, uint8_t port_id, > } > > p->inflight_max = conf->new_event_threshold; > - p->implicit_release = !conf->disable_implicit_release; > + p->implicit_release = !(conf->event_port_cfg & > + RTE_EVENT_PORT_CFG_DISABLE_IMPL_REL); > > /* check if ring exists, same as rx_worker above */ > snprintf(buf, sizeof(buf), "sw%d_p%u, %s", dev->data->dev_id, > @@ -508,7 +509,7 @@ sw_port_def_conf(struct rte_eventdev *dev, uint8_t > port_id, > port_conf->new_event_threshold = 1024; > port_conf->dequeue_depth = 16; > port_conf->enqueue_depth = 16; > - port_conf->disable_implicit_release = 0; > + port_conf->event_port_cfg = 0; > } > > static int > @@ -615,7 +616,8 @@ sw_info_get(struct rte_eventdev *dev, struct > rte_event_dev_info *info) > > RTE_EVENT_DEV_CAP_IMPLICIT_RELEASE_DISABLE| > RTE_EVENT_DEV_CAP_RUNTIME_PORT_LINK | > RTE_EVENT_DEV_CAP_MULTIPLE_QUEUE_PORT | > - RTE_EVENT_DEV_CAP_NONSEQ_MODE), > + RTE_EVENT_DEV_CAP_NONSEQ_MODE | > + RTE_EVENT_DEV_CAP_CARRY_FLOW_ID), > }; > > *info = evdev_sw_info; > diff --git a/drivers/event/sw/sw_evdev_selftest.c > b/drivers/event/sw/sw_evdev_selftest.c > index 38c21fa..4a7d823 100644 > --- a/drivers/event/sw/sw_evdev_selftest.c > +++ b/drivers/event/sw/sw_evdev_selftest.c > @@ -172,7 +172,6 @@ create_ports(struct test *t, int num_ports) > .new_event_threshold = 1024, > .dequeue_depth = 32, > .enqueue_depth = 64, > - .disable_implicit_release = 0, > }; > if (num_ports > MAX_PORTS) > return -1; > @@ -1227,7 +1226,6 @@ port_reconfig_credits(struct test *t) > .new_event_threshold = 128, > .dequeue_depth = 32, > .enqueue_depth = 64, > - .disable_implicit_release = 0, > }; > if (rte_event_port_setup(evdev, 0, &port_conf) < 0) { > printf("%d Error setting up port\n", __LINE__); > @@ -1317,7 +1315,6 @@ port_single_lb_reconfig(struct test *t) > .new_event_threshold = 128, > .dequeue_depth = 32, > .enqueue_depth = 64, > - .disable_implicit_release = 0, > }; > if (rte_event_port_setup(evdev, 0, &port_conf) < 0) { > printf("%d Error setting up port\n", __LINE__); > @@ -3079,7 +3076,8 @@ worker_loopback(struct test *t, uint8_t > disable_implicit_release) > * only be initialized once - and this needs to be set for multiple runs > */ > conf.new_event_threshold = 512; > - conf.disable_implicit_release = disable_implicit_release; > + conf.event_port_cfg = disable_implicit_release ? > + RTE_EVENT_PORT_CFG_DISABLE_IMPL_REL : 0; > > if (rte_event_port_setup(evdev, 0, &conf) < 0) { > printf("Error setting up RX port\n");
