Hi Ankur,

Please see comment below.

> -----Original Message-----
> From: Ankur Dwivedi <[email protected]>
> Sent: Friday, September 25, 2020 12:59 PM
> To: [email protected]
> Cc: Gujjar, Abhinandan S <[email protected]>;
> [email protected]; [email protected]; Ankur Dwivedi
> <[email protected]>
> Subject: [PATCH v2 3/3] test/event_crypto_adapter: free resources during
> exit
> 
> The resources held by crypto adapter should be freed when the test suite
> exits.
> 
> Signed-off-by: Ankur Dwivedi <[email protected]>
> ---
>  app/test/test_event_crypto_adapter.c | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/app/test/test_event_crypto_adapter.c
> b/app/test/test_event_crypto_adapter.c
> index 572ef9c27..4b09ab3b7 100644
> --- a/app/test/test_event_crypto_adapter.c
> +++ b/app/test/test_event_crypto_adapter.c
> @@ -899,6 +899,20 @@ testsuite_setup(void)
>       return TEST_SUCCESS;
>  }
> 
> +static void
> +crypto_adapter_teardown(void)
> +{
> +     int ret;
> +
> +     crypto_adapter_setup_done = 0;
Call rte_event_crypto_adapter_stop() here?
> +     ret =
> rte_event_crypto_adapter_queue_pair_del(TEST_ADAPTER_ID,
> +                                     TEST_CDEV_ID, TEST_CDEV_QP_ID);
> +     if (ret < 0)
> +             RTE_LOG(ERR, USER1, "Failed to delete queue pair!");
> +
> +     rte_event_crypto_adapter_free(TEST_ADAPTER_ID);
> +}
> +
>  static void
>  crypto_teardown(void)
>  {
> @@ -941,6 +955,7 @@ eventdev_teardown(void)  static void
>  testsuite_teardown(void)
>  {
> +     crypto_adapter_teardown();
>       crypto_teardown();
>       eventdev_teardown();
>  }
> --
> 2.28.0

Reply via email to