Hi Jeff, >-----Original Message----- >From: Guo, Jia <[email protected]> >Sent: Friday 9 October 2020 04:03 >To: Power, Ciara <[email protected]>; [email protected] >Cc: Xing, Beilei <[email protected]> >Subject: RE: [PATCH v3 04/18] net/i40e: add checks for max SIMD bitwidth > >Hi, power > >> -----Original Message----- >> From: Power, Ciara <[email protected]> >> Sent: Wednesday, September 30, 2020 9:04 PM >> To: [email protected] >> Cc: Power, Ciara <[email protected]>; Xing, Beilei >> <[email protected]>; Guo, Jia <[email protected]> >> Subject: [PATCH v3 04/18] net/i40e: add checks for max SIMD bitwidth >> >> When choosing a vector path to take, an extra condition must be >> satisfied to ensure the max SIMD bitwidth allows for the CPU enabled path. >> >> Cc: Beilei Xing <[email protected]> >> Cc: Jeff Guo <[email protected]> >> >> Signed-off-by: Ciara Power <[email protected]> >> --- >> drivers/net/i40e/i40e_rxtx.c | 19 +++++++++++++------ >> 1 file changed, 13 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/net/i40e/i40e_rxtx.c >> b/drivers/net/i40e/i40e_rxtx.c index 60b33d20a1..9b535b52fa 100644 >> --- a/drivers/net/i40e/i40e_rxtx.c >> +++ b/drivers/net/i40e/i40e_rxtx.c >> @@ -3098,7 +3098,8 @@ static eth_rx_burst_t >> i40e_get_latest_rx_vec(bool >> scatter) { #if defined(RTE_ARCH_X86) && defined(CC_AVX2_SUPPORT) -if >> (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2)) >> +if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) && >> +rte_get_max_simd_bitwidth() >= > >Nitpick: I think if consistent to keep alignment for open parenthesis in this >patch set would be better. Do you think so? >
This file doesn't seem to have any if statements indented as you suggest, Some do have a double indent for the continued line as I have done here though. <snip> Thanks, Ciara
