> On Thu, Sep 24, 2020 at 02:22:03PM +0000, John Alexander wrote: > > Hi, > > > > I've submitted a patch that uses new features of Meson, specifically the > directory patch aspect of the subproject feature. This requires a minimum > Meson version of 0.55.0. How do we go about getting the community to > accept a more recent version of Meson and getting the Travis server > upgraded too so the CI builds succeed? > > > > Patch link for reference: http://patches.dpdk.org/patch/78675/ > > > > Kind Regards, > > John Alexander. > > Hi John, > > this meson version change came up for discussion at the last DPDK technical > board meeting, and some concerns were expressed about the jump in > version and how it might impact those trying to package DPDK. > > However, looking at your proposed patch, I wonder though if we really need > to globally bump the meson version, and whether we can limit the > requirements to just windows builds - which is what your patch targets. > Would the following change to your patch work for you? It keeps the > minimum meson version at 0.47.1 but then later does a windows-specific > version check, printing out an error message if requirements not met? > > /Bruce > > $ git diff > diff --git a/config/meson.build b/config/meson.build index > 69f2aeb60..fd48c9828 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -14,6 +14,11 @@ foreach env:supported_exec_envs > set_variable('is_' + env, exec_env == env) endforeach > > +# for windows, we need meson 0.55 > +if is_windows and meson.version().version_compare('< 0.55') > + error('Require meson 0.55 to build on windows') endif > + > # MS linker requires special treatment. > # TODO: use cc.get_linker_id() with Meson >= 0.54 is_ms_linker = > is_windows and (cc.get_id() == 'clang') diff --git a/meson.build b/meson.build > index 9e061c73b..7dba3264e 100644 > --- a/meson.build > +++ b/meson.build > @@ -8,7 +8,7 @@ project('DPDK', 'C', > files('VERSION')).stdout().strip(), > license: 'BSD', > default_options: ['buildtype=release', 'default_library=static'], > - meson_version: '>= 0.55.0' > + meson_version: '>= 0.47.1' > ) > > # set up some global vars for compiler, platform, configuration, etc. >
Hi Bruce, Thanks for the workaround suggestion. That certainly works for me. Kind Regards, John Alexander.
