Hi Abhinandan,

> Hi Akhil,
> 
> If the patch is ok, could you please ack it?
> 
Could you please send the Fixes tag for the original patch which introduced this
Issue? I will add it while applying the patch.

Acked-by: Akhil Goyal <akhil.go...@nxp.com>


> >
> > Hi Akhil,
> >
> > Recently, I observed that test was failing with sw adapter.
> > I noticed that, it was because of some changes went in related to crypto in
> > the past releases.
> > One of the tests, configures a session in turn calls
> > null_crypto_set_session_parameters()
> > which checks for params was failing. As part of fixing & updating the xforms
> > to address this issue, thought of getting rid of algo as well, to make the 
> > test
> > simpler. The test continues to use null cryptodev and does not deal with any
> > encryption or auth.
> >
> > Regards
> > Abhinandan
> >
> > > -----Original Message-----
> > > From: Akhil Goyal <akhil.go...@nxp.com>
> > > Sent: Wednesday, September 23, 2020 12:59 AM
> > > To: Gujjar, Abhinandan S <abhinandan.guj...@intel.com>; dev@dpdk.org;
> > > jer...@marvell.com
> > > Cc: Vangati, Narender <narender.vang...@intel.com>
> > > Subject: RE: [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf
> > > issue
> > >
> > > Hi Abhinandan,
> > >
> > > > This patch updates the xform with right configuration.
> > > > For session based ops, sym session pool is created with valid
> > > > userdata size.
> > > >
> > > > Signed-off-by: Abhinandan Gujjar <abhinandan.guj...@intel.com>
> > > > ---
> > > The patch description do not match with the patch.
> > > I can see that you are changing the cipher algo from AES-CBC to NULL
> > > Without explaining the reason.
> > > Could you please clarify the need of this patch.
> > >
> > > Regards,
> > > Akhil

Reply via email to