On Fri, Oct 9, 2020 at 6:09 PM wangyunjian <wangyunj...@huawei.com> wrote: > > From: Yunjian Wang <wangyunj...@huawei.com> > > The glibc free allows free(NULL) as null operation, > so remove this useless null checks. > > Coverity issue: 357719 > Fixes: da138cd47e06 ("net/octeontx2: handle port reconfigure") > Cc: sta...@dpdk.org > > Signed-off-by: Yunjian Wang <wangyunj...@huawei.com>
Acked-by: Jerin Jacob <jer...@marvell.com> Applied to dpdk-next-net-mrvl/for-main. Thanks > --- > v2: > fix code styles suggested by Stephen Hemminger > --- > drivers/net/octeontx2/otx2_ethdev.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/octeontx2/otx2_ethdev.c > b/drivers/net/octeontx2/otx2_ethdev.c > index 03d81faef..b69b92bf5 100644 > --- a/drivers/net/octeontx2/otx2_ethdev.c > +++ b/drivers/net/octeontx2/otx2_ethdev.c > @@ -1383,10 +1383,8 @@ nix_store_queue_cfg_and_then_release(struct > rte_eth_dev *eth_dev) > return 0; > > fail: > - if (tx_qconf) > - free(tx_qconf); > - if (rx_qconf) > - free(rx_qconf); > + free(tx_qconf); > + free(rx_qconf); > > return -ENOMEM; > } > -- > 2.23.0 >