On 10/10/2020 2:49 AM, Zhang, RobinX wrote:
Hi Ferruh
-----Original Message-----
From: Ferruh Yigit <[email protected]>
Sent: Thursday, October 8, 2020 11:06 PM
To: Zhang, RobinX <[email protected]>; [email protected]
Cc: Xing, Beilei <[email protected]>; Wu, Jingjing
<[email protected]>; Yang, Qiming <[email protected]>; Yang,
SteveX <[email protected]>
Subject: Re: [dpdk-dev] [PATCH 8/8] net/iavf: support check DD bit of a RX
descriptor
On 9/27/2020 8:26 AM, Robin Zhang wrote:
Add implementation of inline API rx_descriptor_done in iavf PMD.
Signed-off-by: Robin Zhang <[email protected]>
---
drivers/net/iavf/iavf_ethdev.c | 1 +
drivers/net/iavf/iavf_rxtx.c | 26 ++++++++++++++++++++++++++
drivers/net/iavf/iavf_rxtx.h | 1 +
3 files changed, 28 insertions(+)
diff --git a/drivers/net/iavf/iavf_ethdev.c
b/drivers/net/iavf/iavf_ethdev.c index 836c09f58..b7a819a0e 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -1417,6 +1417,7 @@ iavf_dev_init(struct rte_eth_dev *eth_dev)
/* assign ops func pointer */
eth_dev->dev_ops = &iavf_eth_dev_ops;
eth_dev->rx_queue_count = iavf_dev_rxq_count;
+ eth_dev->rx_descriptor_done = iavf_dev_rx_desc_done;
eth_dev->rx_descriptor_status = iavf_dev_rx_desc_status;
eth_dev->tx_descriptor_status = iavf_dev_tx_desc_status;
Hi Robin,
'rx_descriptor_done' dev_ops is deprecated, 'rx_descriptor_status' should
provide same information?
Is there a specific reason/need to implement 'rx_descriptor_done'? If not I
will drop this patch.
The purpose of this patch is keep same behavior between i40evf and iavf.
Refer to i40evf commit cbfc6111b5 in dpdk-next-net-intel, 'rx_descriptor_done'
is moved to 'struct rte_eth_dev'.
I see, but for i40evf, the 'rx_descriptor_done' was already there and it will be
removed in 21.11.
I think no need to add a deprecated feature. 'rte_eth_rx_descriptor_status'
replaces it and it is already implemented in iavf.
