> -----Original Message----- > From: Kinsella, Ray <[email protected]> > Sent: Wednesday, October 14, 2020 4:31 AM > To: McDaniel, Timothy <[email protected]>; Jerin Jacob > <[email protected]>; Neil Horman <[email protected]> > Cc: [email protected]; Carrillo, Erik G <[email protected]>; Eads, Gage > <[email protected]>; Van Haaren, Harry <[email protected]> > Subject: Re: [PATCH] eventdev: add PCI probe named convenience function > > > > On 12/10/2020 19:42, Timothy McDaniel wrote: > > Add new internal wrapper function for use by pci drivers as a > > .probe function to attach to an event interface. Same as > > rte_event_pmd_pci_probe, except the caller can specify the name. > > > > Updated rte_event_pmd_pci_probe so as to not duplicate > > code. > > Any reason why this couldn't be __rte_internal then ?
On a related note...should a static function defined in an internal header file be included the version.map file? Doesn't that only pertain to symbols in the .so? Probably harmless if so, but now may be a good time to correct it. Thanks, Gage
