> -----Original Message-----
> From: Ferruh Yigit <[email protected]>
> Sent: Friday, October 23, 2020 6:42 PM
> To: Zhang, Yuying <[email protected]>; [email protected]; Zhang, Qi Z
> <[email protected]>; Xing, Beilei <[email protected]>
> Cc: [email protected]
> Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix virtual channel confiliction
> issue
>
> On 10/19/2020 3:20 AM, Yuying Zhang wrote:
> > i40evf_execute_vf_cmd() uses _atomic_set_cmd() to execute virtual
> > channel commands safely in multi-process mode and multi-thread mode.
> > However, it returns -1 when one process or thread is pending. Add
> > rte_spinlock_trylock() to handle this issue in concurrent scenarios.
> >
>
> Should '_atomic_set_cmd()' removed, since spinlock it added?
>
> > Fixes: 4861cde46116 ("i40e: new poll mode driver")
> > Cc: [email protected]
> >
> > Signed-off-by: Yuying Zhang <[email protected]>
>
> <...>
'_atomic_set_cmd()' is also used for sync with i40evf_handle_aq_msg to handle
the request <-> response.
It is not just used for multi-task. I prefer to keep the atomic.
