Hi John, Thank you for your review.
I will submit a v2 of the patch. Klaus Am 08.07.15 um 18:11 schrieb Mcnamara, John: >> -----Original Message----- >> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Klaus Degner >> Sent: Tuesday, June 30, 2015 12:40 PM >> To: dev at dpdk.org >> Subject: [dpdk-dev] [PATCH] add rx and tx byte counter statistics for >> PCAP PMD >> >> PCAP PMD vdev accounts only rx and tx packet statistics. >> This patch adds support for rx and tx bytes statistics. > Hi, > > Thanks for that. > > Just a few minor comments. > > The subject line should contain the library/module being updated and the body > is repeats, more or less, the same comment twice. Do a git log on the file to > see the standard format. > >> unsigned i; >> - unsigned long rx_total = 0, tx_total = 0, tx_err_total = 0; >> + unsigned long rx_total = 0, tx_total = 0, tx_err_total = 0, >> +rx_b_total = 0, tx_b_total = 0; > This line exceeds the 80 character limit. Maybe separate the rx and tx > initialisations onto separate lines. Or else put them all on separate lines > in line with the Coding Guidelines: > > > http://dpdk.readthedocs.org/en/latest/guidelines/coding_style.html#local-variables > > Run checkpatch on the patch before submission to pick up any issues like this. > > If you make those changes and resubmit as a V2 I'll ack it. > > John. > -- > > >
