> On Nov 2, 2020, at 9:11 AM, Bruce Richardson <[email protected]>
> wrote:
>
> On Thu, Oct 29, 2020 at 10:36:31AM -0500, Dharmik Thakkar wrote:
>> Fix incorrect calculations for LPM adds, LPM deletes,
>> and average cycles in RCU QSBR perf tests
>>
>
> To help review this patch, could you provide some more details in the
> commit log as to what exactly was wrong with the calculation and how this
> patch fixes things?
>
I will update the commit message in the next version. Adding it here as well:
Since, rcu qsbr tests run for ‘RCU_ITERATIONS’ and not ‘ITERATIONS’,
replace ‘ITERATIONS’ with ‘RCU_ITERATIONS’ for calculating adds, deletes, and
cycles.
Also, for multi-writer perf test, each writer only writes half of
NUM_LDEPTH_ROUTE_ENTRIES.
For 2 writers, total adds (or deletes) should be (RCU_ITERATIONS *
NUM_LDEPTH_ROUTE_ENTRIES) instead of
(2 * RCU_ITERATIONS * NUM_LDEPTH_ROUTE_ENTRIES).
Since, for both the single and multi writer tests, total adds/deletes is equal
to (RCU_ITERATIONS * NUM_LDEPTH_ROUTE_ENTRIES),
this has been replaced with a macro ’TOTAL_WRITES’ and furthermore, ‘g_writes’
has been removed since it is always a fixed value
equal to TOTAL_WRITES.
>> Fixes: eff30b59cc2e ("test/lpm: add RCU performance tests")
>> Cc: [email protected]
>> Cc: [email protected]
>>
>> Signed-off-by: Dharmik Thakkar <[email protected]>
>> Reviewed-by: Ruifeng Wang <[email protected]>
