[dpdk-dev] [PATCH] net/octeontx2: register dynamic mbuf timestamp field

[Harman Kalra]

A crash is observed if dynamic mbuf timestamp field is
registered in dev_start, as in most of the applications
rte_eth_timesync_enable is called after dev_start due
to which timestamp field did not get registered.

Signed-off-by: Harman Kalra <hka...@marvell.com>
---
 drivers/net/octeontx2/otx2_ethdev.c | 10 ----------
 drivers/net/octeontx2/otx2_ptp.c    |  9 +++++++++
 2 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/drivers/net/octeontx2/otx2_ethdev.c 
b/drivers/net/octeontx2/otx2_ethdev.c
index f6962be9b..cfb733a4b 100644
--- a/drivers/net/octeontx2/otx2_ethdev.c
+++ b/drivers/net/octeontx2/otx2_ethdev.c
@@ -2219,16 +2219,6 @@ otx2_nix_dev_start(struct rte_eth_dev *eth_dev)
        else
                otx2_nix_timesync_disable(eth_dev);
 
-       if (dev->rx_offload_flags & NIX_RX_OFFLOAD_TSTAMP_F) {
-               rc = rte_mbuf_dyn_rx_timestamp_register(
-                               &dev->tstamp.tstamp_dynfield_offset,
-                               &dev->tstamp.rx_tstamp_dynflag);
-               if (rc != 0) {
-                       otx2_err("Failed to register Rx timestamp field/flag");
-                       return -rte_errno;
-               }
-       }
-
        /* Update VF about data off shifted by 8 bytes if PTP already
         * enabled in PF owning this VF
         */
diff --git a/drivers/net/octeontx2/otx2_ptp.c b/drivers/net/octeontx2/otx2_ptp.c
index ae5a2b7cd..4aa68f578 100644
--- a/drivers/net/octeontx2/otx2_ptp.c
+++ b/drivers/net/octeontx2/otx2_ptp.c
@@ -256,6 +256,15 @@ otx2_nix_timesync_enable(struct rte_eth_dev *eth_dev)
                /* Setting up the function pointers as per new offload flags */
                otx2_eth_set_rx_function(eth_dev);
                otx2_eth_set_tx_function(eth_dev);
+
+               /* Registering dynamic mbuf timestamp field and flag */
+               rc = rte_mbuf_dyn_rx_timestamp_register(
+                               &dev->tstamp.tstamp_dynfield_offset,
+                               &dev->tstamp.rx_tstamp_dynflag);
+               if (rc != 0) {
+                       otx2_err("Failed to register Rx timestamp field/flag");
+                       return -rte_errno;
+               }
        }
 
        rc = otx2_nix_recalc_mtu(eth_dev);
-- 
2.17.1