I think Thomas can add it if he want to merge it in this version. Moreover I think you need to keep the ack between versions and the person who acked before should comment if newer version not ok with him, otherwise he is ok with it. “Using git commit —amend”.
Thomas, correct me if I’m wrong, At least this how I understood the procedure here. Moreover I noticed that you sending the versions as new patch all the time, but for history and comments tracking you should send with versions. V2-v3 ...etc with reply to older version of the patch. BRs, Wisam Jaddo Get Outlook for iOS<https://aka.ms/o0ukef> ________________________________ From: Georgios Katsikas <katsikas...@gmail.com> Sent: Wednesday, November 4, 2020 1:11:09 PM To: Wisam Monther <wis...@nvidia.com> Cc: wis...@mellanox.com <wis...@mellanox.com>; NBU-Contact-Thomas Monjalon <tho...@monjalon.net>; dev@dpdk.org <dev@dpdk.org> Subject: Re: [PATCH] app/flow-perf: configurable rule batches Hi, Is what you are asking possible with a simple git commit --amend? Thanks, Georgios On Wed, Nov 4, 2020 at 10:04 AM Wisam Monther <wis...@nvidia.com<mailto:wis...@nvidia.com>> wrote: Hi, You can add my ack: Acked-by: Wisam Jaddo <wis...@nvidia.com<mailto:wis...@nvidia.com>> Thomas, Do you have comments left here? BRs, Wisam Jaddo From: Georgios Katsikas <katsikas...@gmail.com<mailto:katsikas...@gmail.com>> Sent: Tuesday, November 3, 2020 1:26 PM To: wis...@mellanox.com<mailto:wis...@mellanox.com> Cc: dev@dpdk.org<mailto:dev@dpdk.org> Subject: Re: [PATCH] app/flow-perf: configurable rule batches Hi, Any news on this patch? Is there anything else I could do? Thanks, Georgios
