Hi, > -----Original Message----- > From: Huang, Wei <[email protected]> > Sent: Thursday, November 05, 2020 10:06 > To: [email protected]; Xu, Rosen <[email protected]>; Zhang, Qi Z > <[email protected]> > Cc: [email protected]; Huang, Wei <[email protected]> > Subject: [PATCH v2 2/2] raw/ifpga/base: check pointer adapter before > dereference > > In opae_adapter_destroy(), pointer "adapter" is not validated before passing > it to opae_adapter_shm_free() and opae_adapter_mutex_close() which > dereference it. > > Fixes: e41856b515ce ("raw/ifpga/base: enhance driver reliability in multi- > process") Coverity issue: 363752 > > Signed-off-by: Wei Huang <[email protected]> > --- > v2: fix typo in commit log > --- > drivers/raw/ifpga/base/opae_hw_api.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/raw/ifpga/base/opae_hw_api.c > b/drivers/raw/ifpga/base/opae_hw_api.c > index 600afdea1..d5cd5fe60 100644 > --- a/drivers/raw/ifpga/base/opae_hw_api.c > +++ b/drivers/raw/ifpga/base/opae_hw_api.c > @@ -605,10 +605,12 @@ int opae_adapter_enumerate(struct opae_adapter > *adapter) > */ > void opae_adapter_destroy(struct opae_adapter *adapter) { > - if (adapter && adapter->ops && adapter->ops->destroy) > - adapter->ops->destroy(adapter); > - opae_adapter_shm_free(adapter); > - opae_adapter_mutex_close(adapter); > + if (adapter) { > + if (adapter->ops && adapter->ops->destroy) > + adapter->ops->destroy(adapter); > + opae_adapter_shm_free(adapter); > + opae_adapter_mutex_close(adapter); > + } > } > > /** > -- > 2.29.2
Acked-by: Rosen Xu <[email protected]>
