On Friday, November 6, 2020 8:39 PM, Ferruh Yigit wrote: > On 11/6/2020 2:10 AM, Jiawen Wu wrote: > > Remove rte_panic(), and use rte_atomic_thread_fence() instead of > > rte_smp_[r/w]mb. > > > > Signed-off-by: Jiawen Wu <jiawe...@trustnetic.com> > > Reviewed-by: Ferruh Yigit <ferruh.yi...@intel.com> Applied to > dpdk-next-net/main, thanks. > > > The remaining fix is : > Using compiler attribute directly > > I can see two instances are used: > 1) > drivers/net/txgbe/base/txgbe_dummy.h > 10:#define TUP(x) x##_unused __attribute__((unused)) > > 2) > drivers/net/txgbe/base/txgbe_osdep.h > 152:#define __rte_weak __attribute__((__weak__)) > > > I think 2) simple can be removed completely, since it is not used at all. > > > For 1) can it be moved to osdep.h? like: > > #define TUP(x) x##_unused txgbe_unused > txgbe_osdep.h: #define txgbe_unused __rte_unused
Thanks Ferruh, It's a good way to deal with the remaining warning. There will also be a patch to fix it.
