> -----Original Message----- > From: David Marchand <[email protected]> > Sent: Tuesday, November 10, 2020 9:51 AM > To: McDaniel, Timothy <[email protected]> > Cc: dev <[email protected]>; Carrillo, Erik G <[email protected]>; Eads, > Gage <[email protected]>; Van Haaren, Harry > <[email protected]>; Jerin Jacob Kollanukkaran > <[email protected]>; Thomas Monjalon <[email protected]>; Gaetan > Rivet <[email protected]> > Subject: Re: [dpdk-dev] [PATCH v15 00/23] Add DLB PMD > > On Tue, Nov 10, 2020 at 4:29 PM McDaniel, Timothy > <[email protected]> wrote: > > > > I'm not seeing where we can use librte_pci here. We are already using the > dpdk low level rte_pci_read_config(..) APIs. > > Am I missing something? > > dlb_pci_find_ext_capability is a copy of rte_pci_find_ext_capability > from the pci bus. > > A lot of DLB_PCI_* defines have a librte_pci equivalent. > Plus, if there are generic pci defines needed by DLB, they would > rather belong to librte_pci than a driver. > > > -- > David Marchand
Thanks, David. I missed that. I'll get to work on removing the duplication. Tim
