On Thu, Nov 12, 2020 at 10:42 AM Bruce Richardson <bruce.richard...@intel.com> wrote: > > This patch improves the installation of the examples when "ninja install" is > run. It removes issues with the directory structure being flattened out, and > removes from the install list any examples that are not buildable with built > DPDK code. > > V4: resubmit v3 to retest in CI hopefully with proper patch tracking > > V3: fix issues with building on Windows > > V2: add support for filtering examples that won't build > > Bruce Richardson (4): > examples: fix flattening directory layout on install > examples/l2fwd-keepalive: skip build when no librt > examples: stop processing build file if build is impossible > examples: skip installing unbuildable examples
Thanks Bruce. This series looks good to me. My only comment is about vm_power_manager which won't build without the internal librte_power header. It builds fine with meson, because I guess meson pulls this library directory into the include flags of the example, but it won't build outside. We can skip it in devtools/test-meson-builds.sh but, on the other hand, I would exclude it from installing until it is fixed (in a future release). -- David Marchand
