> -----Original Message-----
> From: Ruifeng Wang <[email protected]>
> Sent: Thursday, November 12, 2020 11:37 AM
> To: Juraj Linkeš <[email protected]>; Honnappa Nagarahalli
> <[email protected]>; [email protected]; Phil Yang
> <[email protected]>; [email protected]; Dharmik Thakkar
> <[email protected]>; [email protected];
> [email protected]; Ajit Khaparde ([email protected])
> <[email protected]>; [email protected]; [email protected]
> Cc: [email protected]; nd <[email protected]>; nd <[email protected]>; nd <[email protected]>;
> nd <[email protected]>
> Subject: RE: [PATCH v8 09/14] ci: switch to generic Arm builds
> 
> 
> > -----Original Message-----
> > From: Juraj Linkeš <[email protected]>
> > Sent: Thursday, November 12, 2020 12:19 AM
> > To: Ruifeng Wang <[email protected]>; Honnappa Nagarahalli
> > <[email protected]>; [email protected]; Phil Yang
> > <[email protected]>; [email protected]; Dharmik Thakkar
> > <[email protected]>; [email protected];
> > [email protected]; Ajit Khaparde ([email protected])
> > <[email protected]>; [email protected];
> > [email protected]
> > Cc: [email protected]; nd <[email protected]>; nd <[email protected]>; nd
> <[email protected]>
> > Subject: RE: [PATCH v8 09/14] ci: switch to generic Arm builds
> >
> >
> >
> > > -----Original Message-----
> > > From: Ruifeng Wang <[email protected]>
> > > Sent: Wednesday, November 11, 2020 3:52 PM
> > > To: Juraj Linkeš <[email protected]>; Honnappa Nagarahalli
> > > <[email protected]>; [email protected]; Phil
> > > Yang <[email protected]>; [email protected]; Dharmik Thakkar
> > > <[email protected]>; [email protected];
> > > [email protected]; Ajit Khaparde ([email protected])
> > > <[email protected]>; [email protected];
> > > [email protected]
> > > Cc: [email protected]; nd <[email protected]>; nd <[email protected]>; nd
> > <[email protected]>
> > > Subject: RE: [PATCH v8 09/14] ci: switch to generic Arm builds
> > >
> > >
> > > > -----Original Message-----
> > > > From: Juraj Linkeš <[email protected]>
> > > > Sent: Wednesday, November 11, 2020 7:46 PM
> > > > To: Honnappa Nagarahalli <[email protected]>;
> > > > [email protected]; Ruifeng Wang <[email protected]>;
> > > > Phil Yang <[email protected]>; [email protected]; Dharmik
> > Thakkar
> > > > <[email protected]>; [email protected];
> > > > [email protected]; Ajit Khaparde
> > ([email protected])
> > > > <[email protected]>; [email protected];
> > > > [email protected]
> > > > Cc: [email protected]; nd <[email protected]>; nd <[email protected]>
> > > > Subject: RE: [PATCH v8 09/14] ci: switch to generic Arm builds
> > > >
> > > >
> > > >
> > > > > -----Original Message-----
> > > > > From: Honnappa Nagarahalli <[email protected]>
> > > > > Sent: Sunday, November 8, 2020 3:43 PM
> > > > > To: Juraj Linkeš <[email protected]>;
> > > > > [email protected]; Ruifeng Wang <[email protected]>;
> > > > Phil
> > > > > Yang <[email protected]>; [email protected]; Dharmik Thakkar
> > > > > <[email protected]>; [email protected];
> > > > > [email protected]; Ajit Khaparde
> > > > > ([email protected]) <[email protected]>;
> > > > > [email protected]; [email protected]
> > > > > Cc: [email protected]; nd <[email protected]>; Honnappa Nagarahalli
> > > > > <[email protected]>; nd <[email protected]>
> > > > > Subject: RE: [PATCH v8 09/14] ci: switch to generic Arm builds
> > > > >
> > > > > <snip>
> > > > >
> > > > > >
> > > > > > Switch to generic build on arm Travis machines to avoid
> > > > > > differences in build configuration caused by different Arm hardware.
> > > > > >
> > > > > > Signed-off-by: Juraj Linkeš <[email protected]>
> > > > > > ---
> > > > > >  .ci/linux-build.sh | 4 ++++
> > > > > >  1 file changed, 4 insertions(+)
> > > > > >
> > > > > > diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh index
> > > > > > d079801d7..7fe0fcfd8
> > > > > > 100755
> > > > > > --- a/.ci/linux-build.sh
> > > > > > +++ b/.ci/linux-build.sh
> > > > > > @@ -33,6 +33,10 @@ if [ "$AARCH64" = "1" ]; then
> > > > > >      OPTS="$OPTS --cross-file config/arm/arm64_armv8_linux_gcc"
> > > > > >  fi
> > > > > >
> > > > > > +if [ "$(uname -m)" = "aarch64" ]; then
> > > > > > +    OPTS="$OPTS -Dmachine=generic"
> > > > > > +fi
> > > > > > +
> > > > > I do not think we should change it by default. We would need to
> > > > > test generic builds as well as the SoC specific build.
> > > > >
> > > >
> > > > I'll drop the patch. Testing without it revealed a failure in
> > > > clang
> > > > Graviton2 build (only in that one build, other build are working fine):
> > > > ../lib/librte_eal/arm/include/rte_atomic_64.h:76:39: error:
> > > > instruction
> > > > requires: lse
> > > >
> > > > Here's the build with full log: https://travis-
> > > > ci.com/github/jlinkes/dpdk/jobs/433176503
> > > >
> > > > I think we need to add a commit that fixes the failure but I don't
> > > > know how to fix it.
> > >
> > > Can you try '-mcpu=native' instead of '-march=native -mtune=native'
> > > for native build?
> > > Clang doesn't support '-march=native'.
> > > Reference can be found here:
> > > https://community.arm.com/developer/tools-software/tools/b/tools-
> > softw
> > > are-
> > > ides-blog/posts/compiler-flags-across-architectures-march-mtune-and-
> > > mc
> > > pu
> > > >
> >
> > Unfortunately, it did not help:
> > Compiler for C supports arguments -mcpu=native: YES
> > Message: Using machine args: ['-mcpu=native'] ...
> > ../lib/librte_eal/arm/include/rte_atomic_64.h:76:39: error:
> > instruction
> > requires: lse
> >
> > Full log here:
> > https://travis-ci.com/github/jlinkes/dpdk/jobs/433414180
> >
> I created a patch to fix this issue:
> http://patches.dpdk.org/patch/84054/
> It fixes build when using native detection on N1 with Clang < version 11.

Thanks for fixing the issue, Ruifeng. Should I add it to this patch series?

> > > > >
> > > > > >  if [ "$BUILD_DOCS" = "1" ]; then
> > > > > >      OPTS="$OPTS -Denable_docs=true"
> > > > > >  fi
> > > > > > --
> > > > > > 2.20.1

Reply via email to