On Fri, Jul 10, 2015 at 04:07:53PM +0000, Mcnamara, John wrote: > > -----Original Message----- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman > > Sent: Tuesday, July 7, 2015 2:44 PM > > To: Thomas Monjalon > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH] mk: enable next abi in static libs > > > > On Tue, Jul 07, 2015 at 05:46:08AM -0700, Thomas Monjalon wrote: > > > Neil, in the meantime, could you please help to check ABI breakage in > > the HEAD? > > > > > Took a look, the only ABI break I see that we need to worry about is the > > one introduced in commit 8eecb3295aed0a979def52245564d03be172a83c. It adds > > a bitfield called lro into the existing uint8_t there, but does so in the > > middle of the set, which pushes the other bits around, breaking ABI. It > > should have been added to the end. > > Hi, > > Is it okay to submit a patch to move it to the end? > Assuming that fixes the problem, I think thats the only thing you can do right now. I expect that will work, but I would run it through the ABI checker to be certain Neil
> John. > -- > > > >