16/11/2020 08:15, Juraj Linkeš: > From: Thomas Monjalon <tho...@monjalon.net> > > 13/11/2020 15:31, Juraj Linkeš: > > > Add an option to automatically discover the host's numa and cpu counts > > > and use those values for a non cross-build. > > > Give users the option to override the per-arch default values or > > > values from cross files by specifying them on the command line with > > > -Dmax_lcores and -Dmax_numa_nodes. > > > > > > Signed-off-by: Juraj Linkeš <juraj.lin...@pantheon.tech> > > > Reviewed-by: Honnappa Nagarahalli <honnappa.nagaraha...@arm.com> > > [...] > > > create mode 100644 buildtools/get_cpu_count.py create mode 100644 > > > buildtools/get_numa_count.py > > > > These new files should be added in the file MAINTAINERS. > > Should I add a new section? I just add them under Build System, > making Bruce the maintainer of these?
If Bruce is OK, it looks fine. > > The recommended pattern is to use - as word separator in script filenames. > > > > Ok, I'll rename them. > > > I'm also worried there is no more review on such general change, especially > > the > > description in meson_options.txt: > > > > > +option('max_lcores', type: 'integer', value: 0, > > > + description: 'maximum number of cores/threads supported by > > > +EAL. Set to positive integer to overwrite per-arch or cross-compilation > > defaults. Set to -1 to detect the number of cores on the build machine.') > > option('max_numa_nodes', type: 'integer', value: 0, > > > + description: 'maximum number of NUMA nodes supported by EAL. Set > > > to > > positive integer to overwrite per-arch or cross-compilation defaults. Set > > to -1 to > > detect the number of numa > > Honnappa reviewed this and Bruce also provided his comments > and he's the only maintainer listed for meson_options.txt. > Who else should review this? Bruce did not ack. I want to do careful reviews myself as well.