Hi,
> -----Original Message----- > From: Walsh, Conor <[email protected]> > Sent: Thursday, November 19, 2020 23:00 > To: Xu, Rosen <[email protected]>; Zhang, Tianfei > <[email protected]>; Pei, Andy <[email protected]> > Cc: [email protected]; [email protected]; Chen, LingliX <[email protected]>; > Walsh, Conor <[email protected]> > Subject: [PATCH] raw/ifpga/base: fix uninitialized variables gcc warning > > On Ubuntu 18.04 using gcc 7.5, gcc sees size and start as possibly being > uninitialized. This patch initialises size and start to correct this warning. > > Exact warning: > ../drivers/raw/ifpga/base/opae_intel_max10.c:488:22: warning: ‘size’ > may be used uninitialized in this function [-Wmaybe-uninitialized] > raw->regs[i].size = size; > ../drivers/raw/ifpga/base/opae_intel_max10.c:484:25: warning: ‘start’ > may be used uninitialized in this function [-Wmaybe-uninitialized] > raw->regs[i].regoff = start; > > Fixes: 45f301724ba7 ("raw/ifpga/base: support sensor") > > Signed-off-by: Conor Walsh <[email protected]> > --- > drivers/raw/ifpga/base/opae_intel_max10.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/raw/ifpga/base/opae_intel_max10.c > b/drivers/raw/ifpga/base/opae_intel_max10.c > index 1a526ea549..1c12a85195 100644 > --- a/drivers/raw/ifpga/base/opae_intel_max10.c > +++ b/drivers/raw/ifpga/base/opae_intel_max10.c > @@ -418,7 +418,7 @@ max10_sensor_init(struct intel_max10_device *dev, > int parent) > int i, ret = 0, offset = 0; > const fdt32_t *num; > const char *ptr; > - u64 start, size; > + u64 start = 0, size = 0; > struct raw_sensor_info *raw; > struct opae_sensor_info *sensor; > char *fdt_root = dev->fdt_root; > -- > 2.25.1 Reviewed-by: Rosen Xu <[email protected]>
