On Mon, Nov 02, 2020 at 02:15:01AM +0000, wangyunjian wrote: > > -----Original Message----- > > From: wangyunjian > > Sent: Tuesday, September 22, 2020 8:06 PM > > To: 'Harman Kalra' <[email protected]> > > Cc: [email protected]; [email protected]; [email protected]; > > Thomas Monjalon <[email protected]>; Lilijun (Jerry) > > <[email protected]>; xudingke <[email protected]>; > > [email protected] > > Subject: RE: [EXT] RE: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set > > error for > > rte_epoll_event > > > > > -----Original Message----- > > > From: Harman Kalra [mailto:[email protected]] > > > Sent: Tuesday, September 22, 2020 6:32 PM > > > To: wangyunjian <[email protected]> > > > Cc: [email protected]; [email protected]; [email protected]; > > > Thomas Monjalon <[email protected]>; Lilijun (Jerry) > > > <[email protected]>; xudingke <[email protected]>; > > > [email protected] > > > Subject: Re: [EXT] RE: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set > > > error for rte_epoll_event > > > > > > On Sat, Sep 19, 2020 at 10:42:30AM +0000, wangyunjian wrote: > > > > External Email > > > > > > > > -------------------------------------------------------------------- > > > > -- > > > > Friendly ping. > > > > > > Hi Wang, > > > > > > I am sorry for the delay in review, I will surely complete the review > > > by end of this week. > > > Can you please elaborate on the specific case/scenario which caused > > > failure i.e. which lead you to this change. > > > > EPOLLERR event will be triggered when an exception occurs. This event will > > be > > set in 'evs.events', we should use 'evs.events' instead of > > 'rev->epdata.event' to > > assign to 'events.epdata.event'. Otherwise, the EPOLLERR event will lost. > > > > Thanks, > > Yunjian > > Hi Harman, > > Is there any ideas on this issue?
Hi Yunjian Fix looks good, apologies for the delay in review. Acked-by: Harman Kalra <[email protected]> > > > > > > > > > Thanks > > > Harman > > > > > > > > > > > > -----Original Message----- > > > > > From: wangyunjian > > > > > Sent: Wednesday, August 26, 2020 6:56 PM > > > > > To: [email protected]; [email protected]; [email protected] > > > > > Cc: '[email protected]' <[email protected]>; 'Thomas > > > > > Monjalon' > > > > > <[email protected]>; Lilijun (Jerry) <[email protected]>; > > > > > xudingke <[email protected]>; [email protected] > > > > > Subject: RE: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error > > > > > for rte_epoll_event > > > > > > > > > > Ping for review, please. > > > > > > > > > > > -----Original Message----- > > > > > > From: wangyunjian > > > > > > Sent: Wednesday, July 15, 2020 10:40 AM > > > > > > To: [email protected]; [email protected] > > > > > > Cc: Lilijun (Jerry) <[email protected]>; xudingke > > > > > > <[email protected]>; wangyunjian <[email protected]>; > > > > > > [email protected] > > > > > > Subject: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error > > > > > > for rte_epoll_event > > > > > > > > > > > > From: Yunjian Wang <[email protected]> > > > > > > > > > > > > The "rev->epdata.event" assigned to "events.epdata.event" > > > > > > directly, which was wrong in case of epoll events. It should be > > > > > > set to the > > > "evs.events". > > > > > > > > > > > > Fixes: 9efe9c6cdcac ("eal/linux: add epoll wrappers") > > > > > > Cc: [email protected] > > > > > > > > > > > > Signed-off-by: Yunjian Wang <[email protected]> > > > > > > --- > > > > > > lib/librte_eal/linux/eal_interrupts.c | 2 +- > > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > > > diff --git a/lib/librte_eal/linux/eal_interrupts.c > > > > > > b/lib/librte_eal/linux/eal_interrupts.c > > > > > > index 13db5c4e8..8a3c95cec 100644 > > > > > > --- a/lib/librte_eal/linux/eal_interrupts.c > > > > > > +++ b/lib/librte_eal/linux/eal_interrupts.c > > > > > > @@ -1237,7 +1237,7 @@ eal_epoll_process_event(struct epoll_event > > > > > > *evs, unsigned int n, > > > > > > events[count].status = RTE_EPOLL_VALID; > > > > > > events[count].fd = rev->fd; > > > > > > events[count].epfd = rev->epfd; > > > > > > - events[count].epdata.event = rev->epdata.event; > > > > > > + events[count].epdata.event = evs[i].events; > > > > > > events[count].epdata.data = rev->epdata.data; > > > > > > if (rev->epdata.cb_fun) > > > > > > rev->epdata.cb_fun(rev->fd, > > > > > > -- > > > > > > 2.23.0 > > > > > > > > > >
