Tested-by: Xie,WeiX < weix....@intel.com> Regards, Xie Wei
> -----Original Message----- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of > dapengx...@intel.com > Sent: Wednesday, December 30, 2020 2:54 PM > To: Wu, Jingjing <jingjing...@intel.com>; Xing, Beilei <beilei.x...@intel.com> > Cc: dev@dpdk.org; Yu, DapengX <dapengx...@intel.com>; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/iavf: fix vector id assignment > > From: YU DAPENG <dapengx...@intel.com> > > When the interrupt handle instance allows none packet I/O interrupts, the > max value of vector_id is set to be less than the number of msix interrupts, > but not equal to it. Which may cause same vector_id is sent to PF with > opcode VIRTCHNL_OP_CONFIG_IRQ_MAP to setup the cause of interrupt > mapping in iavf_config_irq_map(), these are invalid parameters, cause error: > VIRTCHNL_STATUS_ERR_PARAM(-5). So add code to set the max value of > vector_id to be equal to the number of msix interrupts. > > Fixes: d6bde6b5eae9 ("net/avf: enable Rx interrupt") > Cc: sta...@dpdk.org > > Signed-off-by: YU DAPENG <dapengx...@intel.com> > --- > drivers/net/iavf/iavf_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c > index 7e3c26a94..54ea3a36c 100644 > --- a/drivers/net/iavf/iavf_ethdev.c > +++ b/drivers/net/iavf/iavf_ethdev.c > @@ -578,7 +578,7 @@ static int iavf_config_rx_queues_irqs(struct > rte_eth_dev *dev, > qv_map[i].queue_id = i; > qv_map[i].vector_id = vec; > intr_handle->intr_vec[i] = vec++; > - if (vec >= vf->nb_msix) > + if (vec > vf->nb_msix) > vec = IAVF_RX_VEC_START; > } > vf->qv_map = qv_map; > -- > 2.27.0