On 1/5/2021 3:07 AM, Guo, Jia wrote:
-----Original Message----- From: Ferruh Yigit <[email protected]> Sent: Tuesday, January 5, 2021 12:43 AM To: Guo, Jia <[email protected]>; Souvik Dey <[email protected]>; Xing, Beilei <[email protected]>; Zhang, Qi Z <[email protected]> Cc: [email protected]; Kevin Traynor <[email protected]>; Luca Boccassi <[email protected]> Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: issue with ADD VLAN from Guest On 12/16/2020 2:09 AM, Guo, Jia wrote:Acked-by: Jeff Guo <[email protected]<mailto:[email protected]>> From: Souvik Dey <[email protected]> Sent: Tuesday, December 15, 2020 9:28 PM To: Xing, Beilei <[email protected]>; Guo, Jia <[email protected]>; Zhang, Qi Z <[email protected]> Cc: [email protected]; Souvik Dey <[email protected]> Subject: [PATCH v3] net/i40e: issue with ADD VLAN from Guest Reset the configuration of vlan strip that would be change by the pf kernel driver when adding vlan from vf. Application cannot use rte_eth_dev_set_vlan_offload() to set the VLAN_STRIP, as this will only work for the first time when original and current config mismatch, but for all subsequent call it will be ignored. Signed-off-by: Souvik Dey <[email protected]<mailto:[email protected]>>I suggest title: "net/i40e: fix VLAN stripping in VF" Will update the title and some wording in the commit log while merging. And I assume this should be backported, so will add [email protected] tag, but can you please confirm the Linux PF behavior was always same? And if the Linux PF behavior was always same, should we add the DPDK commit as fixes commit, @Qi, @Jeff, what do you think? Other question is, does Linux PF and DPDK PF behave differently on enabling VLAN stripping and should it be unified to be consistent?Yes, it does have different behave when enabling VLAN stripping in DPDK PF and Linux PF, and not always the same in linux PFs, but this patch set could be an workaround in DPDK PF for the compatibility.
OK, and since the patch is safe from Linux PF point of view, I will add following fixline, which is the initial DPDK code that adds VF VLAN add support:
Fixes: 4861cde46116 ("i40e: new poll mode driver")
Cc: [email protected]
--
Thanks,
ferruh
