On Fri, Jan 08, 2021 at 07:14:56PM +0530, Kumar Amber wrote:
> Add support for secondary processes in ioat devices. The update
> allocates a memzone for a primary process or returns it in a
> secondary process.
>
> Signed-off-by: Kumar Amber <kumar.am...@intel.com>
>
> ---
> v5
> * add error check for memzone lookup
> v6
> * fix compilation
> v7
> * include dev ops for secondary
> v8
> * fix wrong memzone alloaction
> ---
> drivers/raw/ioat/ioat_common.c | 16 ++++++++++++++++
> drivers/raw/ioat/ioat_rawdev.c | 15 +++++++++++++++
> 2 files changed, 31 insertions(+)
>
> diff --git a/drivers/raw/ioat/ioat_common.c b/drivers/raw/ioat/ioat_common.c
> index 142e171bc9..da464181a5 100644
> --- a/drivers/raw/ioat/ioat_common.c
> +++ b/drivers/raw/ioat/ioat_common.c
> @@ -215,14 +215,30 @@ idxd_rawdev_create(const char *name, struct rte_device
> *dev,
> goto cleanup;
> }
>
> + /* Allocate memory for the primary process or else return the memory
> + * of primary memzone for the secondary process.
> + */
> snprintf(mz_name, sizeof(mz_name), "rawdev%u_private", rawdev->dev_id);
> mz = rte_memzone_reserve(mz_name, sizeof(struct idxd_rawdev),
> dev->numa_node, RTE_MEMZONE_IOVA_CONTIG);
> + if (rte_eal_process_type() == RTE_PROC_SECONDARY) {
> + mz = rte_memzone_lookup(mz_name);
> + if (mz == NULL) {
> + IOAT_PMD_ERR("Unable lookup memzone for private
> data\n");
> + ret = -ENOMEM;
> + goto cleanup;
> + }
> + rawdev->dev_private = mz->addr;
> + rawdev->dev_ops = ops;
> + rawdev->device = dev;
> + return 0;
> + }
This block you inserted still needs to go two lines further up.
> if (mz == NULL) {
> IOAT_PMD_ERR("Unable to reserve memzone for private data\n");
> ret = -ENOMEM;
> goto cleanup;
> }
> +
You don't need this newline addition.
> rawdev->dev_private = mz->addr;
> rawdev->dev_ops = ops;
> rawdev->device = dev;
> diff --git a/drivers/raw/ioat/ioat_rawdev.c b/drivers/raw/ioat/ioat_rawdev.c
> index 2c88b4369f..922fa20e32 100644
> --- a/drivers/raw/ioat/ioat_rawdev.c
> +++ b/drivers/raw/ioat/ioat_rawdev.c
> @@ -165,9 +165,24 @@ ioat_rawdev_create(const char *name, struct
> rte_pci_device *dev)
> goto cleanup;
> }
>
> + /* Allocate memory for the primary process or else return the memory
> + * of primary memzone for the secondary process.
> + */
> snprintf(mz_name, sizeof(mz_name), "rawdev%u_private", rawdev->dev_id);
> mz = rte_memzone_reserve(mz_name, sizeof(struct rte_ioat_rawdev),
> dev->device.numa_node, RTE_MEMZONE_IOVA_CONTIG);
> + if (rte_eal_process_type() == RTE_PROC_SECONDARY) {
> + mz = rte_memzone_lookup(mz_name);
> + if (mz == NULL) {
> + IOAT_PMD_ERR("Unable lookup memzone for private
> data\n");
> + ret = -ENOMEM;
> + goto cleanup;
> + }
> + rawdev->dev_private = mz->addr;
> + rawdev->dev_ops = &ioat_rawdev_ops;
> + rawdev->device = &dev->device;
> + return 0;
> + }
As above, these new lines need to be inserted where they were in the
previous version.
> if (mz == NULL) {
> IOAT_PMD_ERR("Unable to reserve memzone for private data\n");
> ret = -ENOMEM;
> --
> 2.25.1
>
