On Fri, Jul 17, 2015 at 11:45:10AM +0000, Mcnamara, John wrote: > > -----Original Message----- > > From: Neil Horman [mailto:nhorman at tuxdriver.com] > > Sent: Monday, July 13, 2015 3:00 PM > > To: Mcnamara, John > > Cc: dev at dpdk.org; vladz at cloudius-systems.com > > Subject: Re: [dpdk-dev] [PATCH] ethdev: fix ABI breakage in lro code > > > > > > > - dev_started : 1; /**< Device state: STARTED(1) / > > > > > STOPPED(0). */ > > > > > + dev_started : 1, /**< Device state: STARTED(1) / > > > > > STOPPED(0). */ > > > > > + lro : 1; /**< RX LRO is ON(1) / OFF(0) */ > > > > > > > > > > > > > > > Thank you, I'll ack as soon as Chao confirms its not a problem on ppc Neil > > Hi, > > Just pinging Chao Zhu on this again so that it isn't forgotten. > > Neil, just to be clear, are you looking for a validate-abi.sh check on PPC? > Yes, correct. > Just for context, the lro flag doesn't seem to be used anywhere that would be > affected by endianness: > > $ ag -w "\->lro" > drivers/net/ixgbe/ixgbe_rxtx.c > 3767: if (dev->data->lro) { > 3967: dev->data->lro = 1; > > drivers/net/ixgbe/ixgbe_ethdev.c > 1689: dev->data->lro = 0; > But this data is visible to the outside application, correct? If so then we can't rely on internal-only usage as a guide. If it is only internally visible, then yes, you are correct, endianess is not an issue then neil
> John. > -- > >