Hi Bruce, >-----Original Message----- >From: Richardson, Bruce <[email protected]> >Sent: Thursday 14 January 2021 12:18 >To: [email protected] >Cc: Richardson, Bruce <[email protected]>; [email protected]; >Thomas Monjalon <[email protected]>; Yigit, Ferruh ><[email protected]>; Andrew Rybchenko ><[email protected]>; Power, Ciara <[email protected]>; >Wiles, Keith <[email protected]> >Subject: [PATCH] ethdev: avoid blocking telemetry callback for link status > >When querying the link status via telemetry interface, we don't want the >client to have to wait for multiple seconds for a reply. Therefore use >"rte_eth_link_get_nowait()" rather than "rte_eth_link_get()" in the telemetry >callback. > >Cc: [email protected] >Fixes: c190daedb9b1 ("ethdev: add telemetry callbacks") > >Signed-off-by: Bruce Richardson <[email protected]> >--- > lib/librte_ethdev/rte_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c >index 17ddacc78..1f4545fe0 100644 >--- a/lib/librte_ethdev/rte_ethdev.c >+++ b/lib/librte_ethdev/rte_ethdev.c >@@ -5692,7 +5692,7 @@ eth_dev_handle_port_link_status(const char *cmd >__rte_unused, > if (!rte_eth_dev_is_valid_port(port_id)) > return -1; > >- ret = rte_eth_link_get(port_id, &link); >+ ret = rte_eth_link_get_nowait(port_id, &link); > if (ret < 0) > return -1; > >-- >2.27.0
This change looks good to me. Acked-by: Ciara Power <[email protected]>
