Hi Maxime, > -----Original Message----- > From: Maxime Coquelin <[email protected]> > Sent: Wednesday, January 20, 2021 5:25 AM > To: [email protected]; Xia, Chenbo <[email protected]>; [email protected]; > [email protected]; [email protected] > Cc: Maxime Coquelin <[email protected]> > Subject: [PATCH v2 27/44] net/virtio: add Virtio-user features ops > > This patch introduces new callbacks for getting > and setting Virtio features, and implements them > for the different backend types. > > Signed-off-by: Maxime Coquelin <[email protected]> > --- > drivers/net/virtio/virtio_user/vhost.h | 2 + > drivers/net/virtio/virtio_user/vhost_kernel.c | 150 +++++++++--------- > .../net/virtio/virtio_user/vhost_kernel_tap.c | 23 +++ > .../net/virtio/virtio_user/vhost_kernel_tap.h | 1 + > drivers/net/virtio/virtio_user/vhost_user.c | 64 +++++++- > drivers/net/virtio/virtio_user/vhost_vdpa.c | 38 +++-- > .../net/virtio/virtio_user/virtio_user_dev.c | 5 +- > drivers/net/virtio/virtio_user_ethdev.c | 3 +- > 8 files changed, 190 insertions(+), 96 deletions(-) >
<snip> > + > + ret = vhost_user_write(dev->vhostfd, &msg, NULL, 0); > + if (ret < 0) > + goto err; > + > + ret = vhost_user_read(dev->vhostfd, &msg); > + if (ret < 0) > + goto err; Sorry...just forgot you add a log in vhost_user_write. So it's ok not to log here.. Just ignore my similar comment. Thanks, Chenbo
