On Wed, Jul 22, 2015 at 01:44:14AM +0100, Lu, Wenzhuo wrote: > Hi Bruce, > > > -----Original Message----- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Bruce Richardson > > Sent: Tuesday, July 21, 2015 11:25 PM > > To: dev at dpdk.org > > Subject: [dpdk-dev] [PATCH] ixgbe: fix check for split packets > > > > The check for split packets to be reassembled in the vector ixgbe PMD was > > incorrectly only checking the first 16 elements of the array instead of all > > 32. This > > is fixed by changing the uint32_t values to be uint64_t instead. > > > > Fixes: cf4b4708a88a ("ixgbe: improve slow-path perf with vector scattered > > Rx") > > > > Reported-by: Zoltan Kiss <zoltan.kiss at linaro.org> > > Signed-off-by: Bruce Richardson <bruce.richardson at intel.com> > > --- > > drivers/net/ixgbe/ixgbe_rxtx_vec.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec.c > > b/drivers/net/ixgbe/ixgbe_rxtx_vec.c > > index 9f24849..cdad3e0 100644 > > --- a/drivers/net/ixgbe/ixgbe_rxtx_vec.c > > +++ b/drivers/net/ixgbe/ixgbe_rxtx_vec.c > > @@ -549,7 +549,7 @@ ixgbe_recv_scattered_pkts_vec(void *rx_queue, struct > > rte_mbuf **rx_pkts, > > return 0; > > > > /* happy day case, full burst + no packets to be joined */ > > - const uint32_t *split_fl32 = (uint32_t *)split_flags; > > + const uint64_t *split_fl32 = (uint64_t *)split_flags; > Why not change the name to split_fl64? I don't think it's appropriate to keep > it be split_fl32. > Thanks. > Quite right, that's the obvious change! I'll do a V2.
/Bruce