Re: [dpdk-dev] [PATCH v2 15/37] net/mvpp2: add dsa mode support

[Ferruh Yigit]

On 1/22/2021 7:19 PM, lir...@marvell.com wrote:
From: Liron Himi <lir...@marvell.com>
Extend the config file with 'start-hdr' field.
currently 'eth' (default) and 'dsa' headers are supported.

Signed-off-by: Liron Himi <lir...@marvell.com>

<...>

@@ -575,13 +607,15 @@ mrvl_get_qoscfg(const char *key __rte_unused, const char 
*path,
                                (*cfg)->port[n].mapping_priority =
                                        PP2_CLS_QOS_TBL_IP_PRI;
                        else if (!strncmp(entry, MRVL_TOK_VLAN,
-                               sizeof(MRVL_TOK_VLAN)))
+                               sizeof(MRVL_TOK_VLAN))) {
                                (*cfg)->port[n].mapping_priority =
                                        PP2_CLS_QOS_TBL_VLAN_PRI;
-                       else
-                               rte_exit(EXIT_FAILURE,
+                       } else {
+                               MRVL_LOG(ERR,
                                        "Error in parsing %s value (%s)!\n",
                                        MRVL_TOK_MAPPING_PRIORITY, entry);
+                               return -1;
+                       }

+1 to replace the rte_exit() in PMD;

@@ -628,7 +666,8 @@ mrvl_get_qoscfg(const char *key __rte_unused, const char 
*path,
                } else {
                        if ((*cfg)->port[n].use_global_defaults == 0) {
                                MRVL_LOG(ERR,
-                                        "Default Traffic Class required in custom 
configuration!");
+                                        "Default Traffic Class required in " > +         
                          "custom configuration!");

It is preferred to not break the log strings, if you don't mind I will merge it 
back in the next-net.